From: Neil Armstrong <narmstrong@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Maxime Jourdan <maxi.jourdan@wanadoo.fr>,
Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes.
Date: Thu, 9 Aug 2018 09:53:21 +0200 [thread overview]
Message-ID: <fcbfff13-aec5-c571-3a5e-a3d571505342@baylibre.com> (raw)
In-Reply-To: <3221c65f87f8fd3541e0188186cb0259327cb671.camel@baylibre.com>
On 08/08/2018 10:41, Jerome Brunet wrote:
> On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote:
>> Wrap the canvas node in a syscon node.
>>
>> Signed-off-by: Maxime Jourdan <maxi.jourdan@wanadoo.fr>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> index b8dc4dbb391b..c98198662ae2 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> @@ -423,6 +423,23 @@
>> };
>> };
>>
>> + dmcbus: bus@c8838000 {
>> + compatible = "simple-bus";
>> + reg = <0x0 0xc8838000 0x0 0x1000>;
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges = <0x0 0x0 0x0 0xc8838000 0x0 0x1000>;
>> +
>> + sysctrl_DMC: system-controller@0 {
>> + compatible = "amlogic,gx-dmc-sysctrl", "syscon", "simple-mfd";
>> + reg = <0x0 0x0 0x0 0x1000>;
>> +
>> + canvas: canvas-provider@0 {
>> + compatible = "amlogic,canvas";
>
> If there is only one canvas provider under "sysctrl_DMC" and it has no reg
> property , you should not put a unit-address (@0) here. (same for the
> documentation patch)
>
> You may have seen unit-address without a reg property used elsewhere (ASoC
> simple-card, my recent axg-sound-card), when there is multiple node with the
> same node-name (ex: dai-link).
>
> As Martin pointed out, the DT spec says we should not use unit-address unless
> there is a reg property. We did not get Rob's view on this and we might have to
> update this later on. In your case, unless I missed something, you should
> definitely not have it
>
> nitpick regarding the node-name (canvas-provider). If appropriate, we should try
> to stick to one of the generic names proposed in the spec. I wonder if the
> canvas provider could be viewed as a "memory" or "memory-controller"
It's not really a memory or memory-controller, it's a Lookup Table on top of the memory controller,
nothing really matches here...
>
> So, what about this ? Just a proposition, feel free to comment ;)
>
> sysctrl_DMC: system-controller@0 { compatib
> le = "amlogic,gx-dmc-sysctrl", "syscon", "simple-mfd";> reg =
> <0x0 0x0 0x0 0x1000>;
>
> canvas: memory-controller {
> compatible = "amlogic,canvas";
> }
>
> [...]
>
>
>> + };
>> + };
>> + };
>> +
>> hiubus: bus@c883c000 {
>> compatible = "simple-bus";
>> reg = <0x0 0xc883c000 0x0 0x2000>;
>
>
next prev parent reply other threads:[~2018-08-09 7:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 22:00 [PATCH v2 0/4] soc: amlogic: add meson-canvas Maxime Jourdan
2018-08-07 22:00 ` [PATCH v2 1/4] soc: amlogic: add meson-canvas driver Maxime Jourdan
2018-08-08 7:45 ` Jerome Brunet
2018-08-08 15:10 ` Neil Armstrong
2018-08-10 6:40 ` Maxime Jourdan
2018-08-07 22:00 ` [PATCH v2 2/4] dt-bindings: soc: amlogic: add meson-canvas documentation Maxime Jourdan
2018-08-13 19:07 ` Rob Herring
2018-08-14 2:42 ` Maxime Jourdan
2018-08-14 14:39 ` Rob Herring
2018-08-07 22:00 ` [PATCH v2 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes Maxime Jourdan
2018-08-08 8:41 ` Jerome Brunet
2018-08-09 7:53 ` Neil Armstrong [this message]
2018-08-10 6:42 ` Maxime Jourdan
2018-08-07 22:00 ` [PATCH v2 4/4] drm/meson: convert to the new canvas module Maxime Jourdan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcbfff13-aec5-c571-3a5e-a3d571505342@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxi.jourdan@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).