From: Netanel Belgazal <netanel@annapurnalabs.com>
To: Matt Wilson <msw@amzn.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, dwmw@amazon.com, zorik@annapurnalabs.com,
alex@annapurnalabs.com, saeed@annapurnalabs.com, msw@amazon.com,
aliguori@amazon.com, nafea@annapurnalabs.com
Subject: Re: [PATCH V2 net 13/20] net/ena: change driver's default timeouts
Date: Mon, 5 Dec 2016 20:28:17 +0200 [thread overview]
Message-ID: <fd1b5a55-341e-b215-0f56-a288bb81ceaf@annapurnalabs.com> (raw)
In-Reply-To: <20161205043524.GJ4310@u54ee753d2d1854bda401.ant.amazon.com>
On 12/05/2016 06:35 AM, Matt Wilson wrote:
> On Sun, Dec 04, 2016 at 03:19:31PM +0200, Netanel Belgazal wrote:
>
> ... because? (they turned out to be too aggressive, I believe.)
Yes, The timeout were too aggressive on some specific machines.
>> Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
>> ---
>> drivers/net/ethernet/amazon/ena/ena_com.c | 4 ++--
>> drivers/net/ethernet/amazon/ena/ena_netdev.h | 7 ++++---
>> 2 files changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
>> index 4147d6e..a550c8a 100644
>> --- a/drivers/net/ethernet/amazon/ena/ena_com.c
>> +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
>> @@ -36,9 +36,9 @@
>> /*****************************************************************************/
>>
>> /* Timeout in micro-sec */
>> -#define ADMIN_CMD_TIMEOUT_US (1000000)
>> +#define ADMIN_CMD_TIMEOUT_US (3000000)
>>
>> -#define ENA_ASYNC_QUEUE_DEPTH 4
>> +#define ENA_ASYNC_QUEUE_DEPTH 16
> Why is this changed at the same time?
It related to the too aggressive thresholds.
On some heavy loaded system we reached to a state where the AENQ
was full so the driver missed some events.
>
>> #define ENA_ADMIN_QUEUE_DEPTH 32
>>
>> #define MIN_ENA_VER (((ENA_COMMON_SPEC_VERSION_MAJOR) << \
>> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h
>> index c081fd3..ed42e07 100644
>> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.h
>> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.h
>> @@ -39,6 +39,7 @@
>> #include <linux/interrupt.h>
>> #include <linux/netdevice.h>
>> #include <linux/skbuff.h>
>> +#include <linux/u64_stats_sync.h>
> This change seems unrelated.
Removed to a different patch (will be submitted in a new patchset)
>
>> #include "ena_com.h"
>> #include "ena_eth_com.h"
>> @@ -100,7 +101,7 @@
>> /* Number of queues to check for missing queues per timer service */
>> #define ENA_MONITORED_TX_QUEUES 4
>> /* Max timeout packets before device reset */
>> -#define MAX_NUM_OF_TIMEOUTED_PACKETS 32
>> +#define MAX_NUM_OF_TIMEOUTED_PACKETS 128
>>
>> #define ENA_TX_RING_IDX_NEXT(idx, ring_size) (((idx) + 1) & ((ring_size) - 1))
>>
>> @@ -116,9 +117,9 @@
>> #define ENA_IO_IRQ_IDX(q) (ENA_IO_IRQ_FIRST_IDX + (q))
>>
>> /* ENA device should send keep alive msg every 1 sec.
>> - * We wait for 3 sec just to be on the safe side.
>> + * We wait for 6 sec just to be on the safe side.
>> */
>> -#define ENA_DEVICE_KALIVE_TIMEOUT (3 * HZ)
>> +#define ENA_DEVICE_KALIVE_TIMEOUT (6 * HZ)
>>
>> #define ENA_MMIO_DISABLE_REG_READ BIT(0)
>>
next prev parent reply other threads:[~2016-12-05 18:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 13:19 [PATCH V2 net 00/20] Increase ENA driver version to 1.1.2 Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 01/20] net/ena: remove ntuple filter support from device feature list Netanel Belgazal
2016-12-05 4:08 ` Matt Wilson
2016-12-04 13:19 ` [PATCH V2 net 02/20] net/ena: fix error handling when probe fails Netanel Belgazal
2016-12-05 4:09 ` Matt Wilson
2016-12-05 18:23 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 03/20] net/ena: fix queues number calculation Netanel Belgazal
2016-12-05 4:11 ` Matt Wilson
2016-12-05 18:25 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration Netanel Belgazal
2016-12-05 4:18 ` Matt Wilson
2016-12-05 18:26 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration Netanel Belgazal
2016-12-05 4:20 ` Matt Wilson
2016-12-05 18:32 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild Netanel Belgazal
2016-12-05 4:29 ` Matt Wilson
2016-12-05 18:30 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe Netanel Belgazal
2016-12-05 4:24 ` Matt Wilson
2016-12-05 18:29 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver Netanel Belgazal
2016-12-05 4:31 ` Matt Wilson
2016-12-05 18:31 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 09/20] net/ena: fix potential access to freed memory during device reset Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode Netanel Belgazal
2016-12-05 5:45 ` Eric Dumazet
2016-12-05 18:29 ` Netanel Belgazal
2016-12-05 18:51 ` Eric Dumazet
2016-12-04 13:19 ` [PATCH V2 net 11/20] net/ena: use READ_ONCE to access completion descriptors Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 12/20] net/ena: reduce the severity of ena printouts Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 13/20] net/ena: change driver's default timeouts Netanel Belgazal
2016-12-05 4:35 ` Matt Wilson
2016-12-05 18:28 ` Netanel Belgazal [this message]
2016-12-04 13:19 ` [PATCH V2 net 14/20] net/ena: change condition for host attribute configuration Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 15/20] net/ena: change sizeof() argument to be the type pointer Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 16/20] net/ena: use napi_schedule_irqoff when possible Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 17/20] net/ena: add IPv6 extended protocols to ena_admin_flow_hash_proto Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 18/20] net/ena: remove affinity hint from the driver Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 19/20] net/ena: restructure skb allocation Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 20/20] net/ena: increase driver version to 1.1.2 Netanel Belgazal
2016-12-05 2:37 ` [PATCH V2 net 00/20] Increase ENA " David Miller
2016-12-05 3:30 ` Matt Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1b5a55-341e-b215-0f56-a288bb81ceaf@annapurnalabs.com \
--to=netanel@annapurnalabs.com \
--cc=alex@annapurnalabs.com \
--cc=aliguori@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=msw@amzn.com \
--cc=nafea@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).