From: Chen Yu <chenyu56@huawei.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: <wangbinghui@hisilicon.com>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<suzhuangluan@hisilicon.com>, <kongfei@hisilicon.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH v1 08/12] usb: roles: Add usb role switch notifier.
Date: Tue, 4 Dec 2018 09:07:08 +0800 [thread overview]
Message-ID: <fd1e34c9-51f3-1cf7-61d2-3df56e2f2a70@huawei.com> (raw)
In-Reply-To: <20181203123824.GE24338@kuha.fi.intel.com>
On 2018/12/3 20:38, Heikki Krogerus wrote:
> On Mon, Dec 03, 2018 at 11:45:11AM +0800, Yu Chen wrote:
>> This patch adds notifier for drivers want to be informed of the usb role switch.
>
> I think in this case it would be good to explain a little for what we
> need the notifier for.
>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Cc: John Stultz <john.stultz@linaro.org>
>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Signed-off-by: Yu Chen <chenyu56@huawei.com>
>>
>> --
>> v0:
>> The patch is provided by Heikki Krogerus. I modified and test it
>> on Hikey960 platform.
>
> I don't think I actually made a "patch" for this. The "diff" I made
> showing the idea does not count, so you should not sign off the patch
> with my address.
>
> In this case I believe something like "Suggested-by" should be used
> instead of SoB tag:
>
> Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> Side note: If this was from me, then there should be "from" line with
> my address as well.
>
OK. Thanks!
>> --
>> ---
>> drivers/usb/common/roles.c | 20 +++++++++++++++++++-
>> include/linux/usb/role.h | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 65 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c
>> index 0f48090c5c30..bfd7a988b64c 100644
>> --- a/drivers/usb/common/roles.c
>> +++ b/drivers/usb/common/roles.c
>> @@ -21,6 +21,7 @@ struct usb_role_switch {
>> struct device dev;
>> struct mutex lock; /* device lock*/
>> enum usb_role role;
>> + struct blocking_notifier_head nh;
>>
>> /* From descriptor */
>> struct device *usb2_port;
>> @@ -50,8 +51,10 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role)
>> mutex_lock(&sw->lock);
>>
>> ret = sw->set(sw->dev.parent, role);
>> - if (!ret)
>> + if (!ret) {
>> sw->role = role;
>> + blocking_notifier_call_chain(&sw->nh, role, NULL);
>> + }
>>
>> mutex_unlock(&sw->lock);
>>
>> @@ -59,6 +62,20 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role)
>> }
>> EXPORT_SYMBOL_GPL(usb_role_switch_set_role);
>>
>> +int usb_role_switch_register_notifier(struct usb_role_switch *sw,
>> + struct notifier_block *nb)
>> +{
>> + return blocking_notifier_chain_register(&sw->nh, nb);
>> +}
>> +EXPORT_SYMBOL_GPL(usb_role_switch_register_notifier);
>> +
>> +int usb_role_switch_unregister_notifier(struct usb_role_switch *sw,
>> + struct notifier_block *nb)
>> +{
>> + return blocking_notifier_chain_unregister(&sw->nh, nb);
>> +}
>> +EXPORT_SYMBOL_GPL(usb_role_switch_unregister_notifier);
>> +
>> /**
>> * usb_role_switch_get_role - Get the USB role for a switch
>> * @sw: USB role switch
>> @@ -297,6 +314,7 @@ usb_role_switch_register(struct device *parent,
>> return ERR_PTR(-ENOMEM);
>>
>> mutex_init(&sw->lock);
>> + BLOCKING_INIT_NOTIFIER_HEAD(&sw->nh);
>>
>> sw->allow_userspace_control = desc->allow_userspace_control;
>> sw->usb2_port = desc->usb2_port;
>> diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h
>> index edc51be4a77c..c97d4be91ada 100644
>> --- a/include/linux/usb/role.h
>> +++ b/include/linux/usb/role.h
>> @@ -40,6 +40,8 @@ struct usb_role_switch_desc {
>> bool allow_userspace_control;
>> };
>>
>> +
>> +#if IS_ENABLED(CONFIG_USB_ROLE_SWITCH)
>> int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role);
>> enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw);
>> struct usb_role_switch *usb_role_switch_get(struct device *dev);
>> @@ -49,5 +51,49 @@ struct usb_role_switch *
>> usb_role_switch_register(struct device *parent,
>> const struct usb_role_switch_desc *desc);
>> void usb_role_switch_unregister(struct usb_role_switch *sw);
>> +int usb_role_switch_register_notifier(struct usb_role_switch *sw,
>> + struct notifier_block *nb);
>> +int usb_role_switch_unregister_notifier(struct usb_role_switch *sw,
>> + struct notifier_block *nb);
>> +#else
>> +static inline int usb_role_switch_set_role(struct usb_role_switch *sw,
>> + enum usb_role role)
>> +{
>> + return 0;
>> +}
>> +
>> +static inline enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw)
>> +{
>> + return USB_ROLE_NONE;
>> +}
>> +
>> +static inline struct usb_role_switch *usb_role_switch_get(struct device *dev)
>> +{
>> + return ERR_PTR(-ENODEV);
>> +}
>> +
>> +static inline void usb_role_switch_put(struct usb_role_switch *sw) { }
>> +
>> +static inline struct usb_role_switch *
>> +usb_role_switch_register(struct device *parent,
>> + const struct usb_role_switch_desc *desc)
>> +{
>> + return ERR_PTR(-ENODEV);
>> +}
>> +
>> +static inline void usb_role_switch_unregister(struct usb_role_switch *sw) { }
>> +
>> +static int usb_role_switch_register_notifier(struct usb_role_switch *sw,
>> + struct notifier_block *nb)
>> +{
>> + return -ENODEV;
>> +}
>> +
>> +static int usb_role_switch_unregister_notifier(struct usb_role_switch *sw,
>> + struct notifier_block *nb)
>> +{
>> + return -ENODEV;
>> +}
>> +#endif
>>
>> #endif /* __LINUX_USB_ROLE_H */
>> --
>> 2.15.0-rc2
>
> thanks,
>
next prev parent reply other threads:[~2018-12-04 1:07 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 3:45 [PATCH v1 00/12] Add support for usb on Hikey960 Yu Chen
2018-12-03 3:45 ` [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs Yu Chen
2018-12-03 8:35 ` Sergei Shtylyov
2018-12-03 8:51 ` Chen Yu
2018-12-03 8:59 ` Sergei Shtylyov
2018-12-03 9:28 ` Chen Yu
2018-12-19 14:09 ` Rob Herring
2018-12-20 1:33 ` Chen Yu
2018-12-20 6:46 ` Felipe Balbi
2018-12-20 13:48 ` Rob Herring
2018-12-03 3:45 ` [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2018-12-19 14:14 ` Rob Herring
2018-12-20 1:52 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2018-12-19 14:21 ` Rob Herring
2018-12-20 2:02 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform Yu Chen
2018-12-03 8:12 ` Andy Shevchenko
2018-12-03 8:30 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen
2018-12-03 8:02 ` Andy Shevchenko
2018-12-03 8:23 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2018-12-03 8:14 ` Andy Shevchenko
2018-12-03 3:45 ` [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node Yu Chen
2018-12-03 8:17 ` Andy Shevchenko
2018-12-03 12:25 ` Heikki Krogerus
2019-01-21 8:36 ` Chen Yu
2019-01-21 13:51 ` Heikki Krogerus
2019-01-25 12:35 ` Heikki Krogerus
2018-12-03 3:45 ` [PATCH v1 08/12] usb: roles: Add usb role switch notifier Yu Chen
2018-12-03 12:38 ` Heikki Krogerus
2018-12-04 1:07 ` Chen Yu [this message]
2018-12-03 3:45 ` [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2018-12-03 9:15 ` Andy Shevchenko
2018-12-03 9:30 ` Chen Yu
2018-12-03 12:43 ` Heikki Krogerus
2018-12-04 10:54 ` Heikki Krogerus
2018-12-05 0:56 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2018-12-03 9:23 ` Andy Shevchenko
2018-12-04 1:40 ` Chen Yu
2018-12-04 17:47 ` Andy Shevchenko
2018-12-05 1:57 ` Chen Yu
2018-12-05 8:44 ` Andy Shevchenko
2018-12-03 3:45 ` [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2018-12-03 9:25 ` Andy Shevchenko
2018-12-04 1:22 ` Chen Yu
2018-12-03 9:53 ` Krzysztof Opasiak
2018-12-03 3:45 ` [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2018-12-04 12:45 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1e34c9-51f3-1cf7-61d2-3df56e2f2a70@huawei.com \
--to=chenyu56@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=suzhuangluan@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).