From: Randy Dunlap <rdunlap@infradead.org>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Jani Nikula <jani.nikula@linux.intel.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] linux-next: Tree for Nov 19 (i915)
Date: Wed, 20 Nov 2019 13:54:29 -0800 [thread overview]
Message-ID: <fd7a54c4-99b4-abb2-15d1-96324fdff111@infradead.org> (raw)
In-Reply-To: <157426899658.13839.6346197595846229766@skylake-alporthouse-com>
On 11/20/19 8:56 AM, Chris Wilson wrote:
> Quoting Jani Nikula (2019-11-20 16:15:08)
>> On Tue, 19 Nov 2019, Randy Dunlap <rdunlap@infradead.org> wrote:
>>> On 11/19/19 12:46 AM, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20191118:
>>>
>>>
>>> on x86_64:
>>>
>>> ERROR: "pm_suspend_target_state" [drivers/gpu/drm/i915/i915.ko] undefined!
>>>
>>> # CONFIG_SUSPEND is not set
>>
>> a70a9e998e8e ("drm/i915: Defer rc6 shutdown to suspend_late")
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index 060ee0f44c70..982040ecbd01 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -275,7 +275,7 @@ void intel_gt_suspend_prepare(struct intel_gt *gt)
>
> static suspend_state_t pm_suspend_target(void)
> {
> -#if IS_ENABLED(CONFIG_PM_SLEEP)
> +#if IS_ENABLED(CONFIG_SUSPEND) && IS_ENABLED(CONFIG_PM_SLEEP)
>
> Declared under PM_SLEEP.
> Defined under SUSPEND.
> -Chris
Aside from being a slightly incomplete patch (missing 3 ending context lines),
this works fine. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
--
~Randy
next prev parent reply other threads:[~2019-11-20 21:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 8:46 linux-next: Tree for Nov 19 Stephen Rothwell
2019-11-19 15:11 ` linux-next: Tree for Nov 19 (kcsan) Randy Dunlap
2019-11-19 16:12 ` Marco Elver
2019-11-19 16:50 ` Randy Dunlap
2019-11-19 18:34 ` Marco Elver
2019-11-19 18:57 ` [PATCH -next] kcsan, ubsan: Make KCSAN+UBSAN work together Marco Elver
2019-11-19 20:16 ` Paul E. McKenney
2019-11-19 21:07 ` Randy Dunlap
2019-11-19 21:17 ` Paul E. McKenney
2019-11-19 19:02 ` linux-next: Tree for Nov 19 (kcsan) Qian Cai
2019-11-19 19:05 ` Marco Elver
2019-11-19 20:14 ` Paul E. McKenney
2019-11-19 15:13 ` linux-next: Tree for Nov 19 (bpf) Randy Dunlap
2019-11-27 23:45 ` linux-next: Tree for Nov 19 (bpf/btf) Randy Dunlap
2019-11-19 15:33 ` linux-next: Tree for Nov 19 (i915) Randy Dunlap
2019-11-20 16:15 ` [Intel-gfx] " Jani Nikula
2019-11-20 16:56 ` Chris Wilson
2019-11-20 21:54 ` Randy Dunlap [this message]
2019-11-19 15:38 ` linux-next: Tree for Nov 19 (objtool) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd7a54c4-99b4-abb2-15d1-96324fdff111@infradead.org \
--to=rdunlap@infradead.org \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).