From: Stefan Wahren <stefan.wahren@i2se.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: Applied "ASoC: core: ensure component names are unique" to the asoc tree
Date: Mon, 17 Feb 2020 18:23:21 +0100 [thread overview]
Message-ID: <feb041d5-ed81-31fd-aa6a-23a902624f57@i2se.com> (raw)
In-Reply-To: <20557448-d6d2-7584-e2ac-c46d337e1778@samsung.com>
Am 17.02.20 um 15:36 schrieb Marek Szyprowski:
> Hi Jerome,
>
> On 17.02.2020 14:18, Jerome Brunet wrote:
>> On Mon 17 Feb 2020 at 13:13, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>>> On 14.02.2020 21:56, Mark Brown wrote:
>>>> Thanks,
>>>> Mark
>>>>
>>>> From b2354e4009a773c00054b964d937e1b81cb92078 Mon Sep 17 00:00:00 2001
>>>> From: Jerome Brunet <jbrunet@baylibre.com>
>>>> Date: Fri, 14 Feb 2020 14:47:04 +0100
>>>> Subject: [PATCH] ASoC: core: ensure component names are unique
>>>>
>>>> Make sure each ASoC component is registered with a unique name.
>>>> The component is derived from the device name. If a device registers more
>>>> than one component, the component names will be the same.
>>>>
>>>> This usually brings up a warning about the debugfs directory creation of
>>>> the component since directory already exists.
>>>>
>>>> In such case, start numbering the component of the device so the names
>>>> don't collide anymore.
>>>>
>>>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>>>> Link: https://lore.kernel.org/r/20200214134704.342501-1-jbrunet@baylibre.com
>>>> Signed-off-by: Mark Brown <broonie@kernel.org>
>>> This patch landed in today's linux-next and I've noticed that it breaks
>>> registration of VC4 DRM driver on Raspberry Pi3 boards (I've compiled
>>> kernel from bcm2835_defconfig):
>> I think I have an idea about what is going on. (good catch in the defer BTW)
>>
>> 1) Funny to see that the vc4-hdmi already registers several (3) ASoC
>> components. It must have had warning about the debugfs entry before this patch.
> Okay, right, before this patch there is a warning from debugfs I've
> missed (debugfs was not enabled in bcm2835_defconfig):
This is unintended. I've seen patches which restored DEBUG_FS support
because of this commit:
0e4a459f56c32d tracing: Remove unnecessary DEBUG_FS dependency
Best regards
Stefan
next prev parent reply other threads:[~2020-02-17 17:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:47 [PATCH RFC] ASoC: core: ensure component names are unique Jerome Brunet
2020-02-14 20:56 ` Applied "ASoC: core: ensure component names are unique" to the asoc tree Mark Brown
[not found] ` <CGME20200217121336eucas1p2deb35417f5c4646a89762fd6146c3cf9@eucas1p2.samsung.com>
2020-02-17 12:13 ` Marek Szyprowski
2020-02-17 13:18 ` Jerome Brunet
2020-02-17 14:36 ` Marek Szyprowski
2020-02-17 17:23 ` Stefan Wahren [this message]
2020-02-17 18:06 ` [RFT/DONTMERGE] ASoC: devm_snd_soc_register_component fixup Jerome Brunet
2020-02-18 6:47 ` Marek Szyprowski
2020-02-18 9:32 ` Jerome Brunet
2020-02-17 13:22 ` [alsa-devel] Applied "ASoC: core: ensure component names are unique" to the asoc tree Peter Ujfalusi
2020-02-18 18:55 ` Jerome Brunet
2020-02-18 19:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feb041d5-ed81-31fd-aa6a-23a902624f57@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).