From: Michael Riesch <michael.riesch@wolfvision.net>
To: pgwipeout@gmail.com
Cc: devicetree@vger.kernel.org, heiko@sntech.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
robh+dt@kernel.org
Subject: Re: [PATCH v2 7/8] arm64: dts: rockchip: add usb2 nodes to rk3568 device tree
Date: Thu, 14 Oct 2021 12:02:48 +0200 [thread overview]
Message-ID: <fecdda76-6eaf-9cf7-09d3-e2025ad1297b@wolfvision.net> (raw)
In-Reply-To: <20210812204116.2303617-8-pgwipeout@gmail.com>
Hi Peter,
One cosmetic issue/question:
> [...]
> @@ -738,6 +792,50 @@ saradc: saradc@fe720000 {
> status = "disabled";
> };
>
> + usb2phy0: usb2-phy@fe8a0000 {
> + compatible = "rockchip,rk3568-usb2phy";
> + reg = <0x0 0xfe8a0000 0x0 0x10000>;
> + clocks = <&pmucru CLK_USBPHY0_REF>;
> + clock-names = "phyclk";
> + clock-output-names = "clk_usbphy0_480m";
> + interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
> + rockchip,usbgrf = <&usb2phy0_grf>;
> + #clock-cells = <0>;
> + status = "disabled";
> +
> + u2phy0_host: host-port {
> + #phy-cells = <0>;
> + status = "disabled";
> + };
> +
> + u2phy0_otg: otg-port {
> + #phy-cells = <0>;
> + status = "disabled";
> + };
Would it make sense to name those usb2phy0_{host,otg}? This would clean
up the sorting in the dts files a bit. Otherwise, u2phy... and
usb2phy... would have to be separated by e.g. uart nodes.
> + };
> +
> + usb2phy1: usb2-phy@fe8b0000 {
> + compatible = "rockchip,rk3568-usb2phy";
> + reg = <0x0 0xfe8b0000 0x0 0x10000>;
> + clocks = <&pmucru CLK_USBPHY1_REF>;
> + clock-names = "phyclk";
> + clock-output-names = "clk_usbphy1_480m";
> + interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> + rockchip,usbgrf = <&usb2phy1_grf>;
> + #clock-cells = <0>;
> + status = "disabled";
> +
> + u2phy1_host: host-port {
> + #phy-cells = <0>;
> + status = "disabled";
> + };
> +
> + u2phy1_otg: otg-port {
> + #phy-cells = <0>;
> + status = "disabled";
> + };
Same here, of course.
> + };
> +
> [...]
Best regards,
Michael
next prev parent reply other threads:[~2021-10-14 10:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 20:41 [PATCH v2 0/8] phy-rockchip-inno-usb2: support rk356x usb2phy Peter Geis
2021-08-12 20:41 ` [PATCH v2 1/8] dt-bindings: soc: rockchip: add rk3568-usb2phy-grf Peter Geis
2021-08-17 21:31 ` Rob Herring
2021-08-12 20:41 ` [PATCH v2 2/8] dt-bindings: phy: phy-rockchip-inno-usb2: add rk3568 documentation Peter Geis
2021-08-17 16:52 ` Johan Jonker
2021-08-17 21:43 ` Rob Herring
2021-08-12 20:41 ` [PATCH v2 3/8] phy: phy-rockchip-inno-usb2: support #address_cells = 2 Peter Geis
2021-08-12 20:41 ` [PATCH v2 4/8] phy: phy-rockchip-inno-usb2: support standalone phy nodes Peter Geis
2021-08-12 20:41 ` [PATCH v2 5/8] phy: phy-rockchip-inno-usb2: support muxed interrupts Peter Geis
2021-08-12 20:41 ` [PATCH v2 6/8] phy: phy-rockchip-inno-usb2: add rk3568 support Peter Geis
2021-08-12 20:41 ` [PATCH v2 7/8] arm64: dts: rockchip: add usb2 nodes to rk3568 device tree Peter Geis
2021-10-14 10:02 ` Michael Riesch [this message]
2021-08-12 20:41 ` [PATCH v2 8/8] arm64: dts: rockchip: add Quartz64-A usb2 support Peter Geis
2021-10-14 10:11 ` [PATCH v2 0/8] phy-rockchip-inno-usb2: support rk356x usb2phy Michael Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fecdda76-6eaf-9cf7-09d3-e2025ad1297b@wolfvision.net \
--to=michael.riesch@wolfvision.net \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).