From: David Lechner <david@lechnology.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>
Cc: Baolin Wang <baolin.wang@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface
Date: Wed, 18 Jul 2018 17:13:41 -0500 [thread overview]
Message-ID: <ffc9cf0e-7159-e91b-477e-253246210200@lechnology.com> (raw)
In-Reply-To: <0e0cd8f7-dc73-6733-65f2-9a14506b0f0e@gmail.com>
On 07/18/2018 02:22 PM, Jacek Anaszewski wrote:
> On 07/18/2018 08:54 PM, Jacek Anaszewski wrote:
>> On 07/18/2018 09:56 AM, Pavel Machek wrote:
>>> Hi!
>>>
>>>>>>>> I believe I meant "changing patterns from kernel in response to events
>>>>>>>> is probably overkill"... or something like that.
>>>>>>>
>>>>>>> Anyway -- to clean up the confusion -- I'd like to see
>>>>>>>
>>>>>>> echo pattern > trigger
>>>>>>> echo "1 2 3 4 5 6 7 8" > somewhere
>>>>>>
>>>>>> s/somewhere/pattern/
>>>>>>
>>>>>> pattern trigger should create "pattern" file similarly how ledtrig-timer
>>>>>> creates delay_{on|off} files.
>>>
>>> Yes, that sounds reasonable. v5 still says
>>>
>>> + Writing non-empty string to this file will activate the pattern,
>>> + and empty string will disable the pattern.
>>>
>>> I'd deactivate the pattern by simply writing something else to the
>>> trigger file.
>>
>> Please keep in mind that this is ABI documentation for the pattern file
>> to be exposed by LED core, and not by the pattern trigger, that, as we
>> agreed, will be implemented later. In this case, I'd go for
>
> Gosh, I got completely distracted by the recent discussion about
> pattern synchronization.
>
> So, to recap, we need to decide if we are taking Baolin's solution
> or we're opting for implementing pattern trigger.
I think we should take Baolin's solution.
>
> If we choose the latter, then we will also need some software
> pattern engine in the trigger, to be applied as a software pattern
> fallback for the devices without hardware pattern support.
> It will certainly delay the contribution process, provided that Baolin
> would find time for this work at all.
>
> I'd just take v5 based solution for now (with improved semantics
> of disabling pattern - in this case my reasoning from the message
> I'm replying to is still valid),
>
>> "echo 0 > brightness" as a command disabling pattern. The same operation
>> disables triggers, so later transition to using pattern trigger will be
>> seamless for userspace.
>>
>
next prev parent reply other threads:[~2018-07-18 22:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 5:03 [PATCH v3 1/2] leds: core: Introduce generic pattern interface Baolin Wang
2018-06-29 5:03 ` [PATCH v3 2/2] leds: sc27xx: Add pattern_set/get/clear interfaces for LED controller Baolin Wang
2018-07-11 11:02 ` [PATCH v3 1/2] leds: core: Introduce generic pattern interface Baolin Wang
2018-07-11 21:10 ` Jacek Anaszewski
2018-07-12 12:24 ` Baolin Wang
2018-07-12 21:41 ` Jacek Anaszewski
2018-07-13 1:58 ` Baolin Wang
2018-07-14 21:20 ` Pavel Machek
2018-07-14 22:02 ` Jacek Anaszewski
2018-07-14 22:29 ` Pavel Machek
2018-07-14 22:39 ` Pavel Machek
2018-07-15 12:22 ` Jacek Anaszewski
2018-07-16 1:00 ` David Lechner
2018-07-16 20:29 ` Jacek Anaszewski
2018-07-16 21:56 ` Pavel Machek
2018-07-17 20:26 ` Jacek Anaszewski
2018-07-17 21:07 ` Pavel Machek
2018-07-24 0:35 ` Bjorn Andersson
2018-07-18 7:56 ` Pavel Machek
2018-07-18 11:32 ` Baolin Wang
2018-07-18 12:08 ` Pavel Machek
2018-07-18 17:00 ` David Lechner
2018-07-20 19:11 ` Jacek Anaszewski
2018-07-24 0:55 ` Bjorn Andersson
2018-07-18 18:54 ` Jacek Anaszewski
2018-07-18 19:22 ` Jacek Anaszewski
2018-07-18 22:13 ` David Lechner [this message]
2018-07-18 22:17 ` Pavel Machek
2018-07-19 20:20 ` Pavel Machek
2018-07-20 18:08 ` Jacek Anaszewski
2018-07-23 6:59 ` Baolin Wang
2018-07-24 11:41 ` Pavel Machek
2018-07-27 5:15 ` Baolin Wang
2018-07-27 8:36 ` Pavel Machek
2018-07-27 8:41 ` Baolin Wang
2018-07-24 11:50 ` Pavel Machek
2018-07-24 0:18 ` Bjorn Andersson
2018-07-16 11:08 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffc9cf0e-7159-e91b-477e-253246210200@lechnology.com \
--to=david@lechnology.com \
--cc=baolin.wang@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).