From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87AB3C4742C for ; Mon, 16 Nov 2020 13:55:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5483322280 for ; Mon, 16 Nov 2020 13:55:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tessares-net.20150623.gappssmtp.com header.i=@tessares-net.20150623.gappssmtp.com header.b="LUiuPEMb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729736AbgKPNyY (ORCPT ); Mon, 16 Nov 2020 08:54:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728717AbgKPNyW (ORCPT ); Mon, 16 Nov 2020 08:54:22 -0500 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE33AC0613CF for ; Mon, 16 Nov 2020 05:54:20 -0800 (PST) Received: by mail-ej1-x643.google.com with SMTP id y17so18859345ejh.11 for ; Mon, 16 Nov 2020 05:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aD3qfM2yjHhnaLsG2eSOWaWvLo9/5a8N5bYSZ4uCB7Y=; b=LUiuPEMbmS7vgnAVfR+ERX3dRmQvGSdG9XuuqY6sg2/rqrsVHfpklHOazYJrCB0hEA cQLuuLB7ySeXZK247dnTqKW/vW3GjS+2ESt9RHSu+N9Qhx+ZDPNs5IKBUfqTCj0gPdPZ BoG8aof99kghxDkXIz3KLNZ/0+3+pbIephydtlVNr1zEzUDTjMKPYHp1KFm77p0qkbNy OvPkpqdbbvHHwS4TvAa7cBuDmgTDACiqF5vcf96/96SPfxzRwaWNWEQqxfb/ARYFJ/QB +LUHkYDiuAL2B1/AM8GVlROUJ+ZJDPDMcHX8bLG7b4Ni/V7uZwWxof5XTxiylKDIENRm 71NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aD3qfM2yjHhnaLsG2eSOWaWvLo9/5a8N5bYSZ4uCB7Y=; b=Jcq5LwF60qObHA2GX955i+EbLSFRKalQvHGd9UZKYp1vouGhAL3E691Ea3i93ZFwHB CaB1LJnVV4Gu001rQE4rvI8qY36tG4uz9hz23A/YZXH4rLoiNhF9MJDAfuLZxRxUS/9L nFmfwU8E1QG8PdbDh+l9HZ3TwBmPCZIrWsDnD6GlY1qNHQ6MA41lWVQAAd/cOB0HjWvk 3q2FNje2l/OgPnTqYrzcGd3sDrDOtdEKngi9AOputKMnKHz2F+pfoUGrrl5x9Q0Bu05s FY9bMPNPcHOIUZUA/UgmtEZAHnPFRU6h9slk3Nz3oaaA+IC0VHMx8LM/WLcjfv8hBCO7 gsdw== X-Gm-Message-State: AOAM533vRBswyQv4ekV0wID1AnUZV43D4FKC8SKjXj50gNcVXwQXV6Bu jF39IOZkGYoTtk8i22ny2gPNVQ== X-Google-Smtp-Source: ABdhPJz7P8v17bMp5D5XxlovDjHdxIZm7+U5Y8L6o/R+Ow2OUmKHk+O9OrzxUeIxe43EoK3JOXQJqA== X-Received: by 2002:a17:906:60c4:: with SMTP id f4mr14724959ejk.336.1605534859480; Mon, 16 Nov 2020 05:54:19 -0800 (PST) Received: from tsr-lap-08.nix.tessares.net ([2a02:578:85b0:e00:76c5:ace8:67f7:ee5b]) by smtp.gmail.com with ESMTPSA id rp28sm10467307ejb.77.2020.11.16.05.54.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2020 05:54:18 -0800 (PST) To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: kernel test robot , Aleksandr Nogikh , Willem de Bruijn , Jakub Kicinski , linux-next@vger.kernel.org, netdev@vger.kernel.org, Florian Westphal References: <20201116031715.7891-1-rdunlap@infradead.org> From: Matthieu Baerts Subject: Re: [PATCH net-next v4] net: linux/skbuff.h: combine SKB_EXTENSIONS + KCOV handling Message-ID: Date: Mon, 16 Nov 2020 14:54:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201116031715.7891-1-rdunlap@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 16/11/2020 04:17, Randy Dunlap wrote: > The previous Kconfig patch led to some other build errors as > reported by the 0day bot and my own overnight build testing. > > These are all in when KCOV is enabled but > SKB_EXTENSIONS is not enabled, so fix those by combining those conditions > in the header file. > > Also, add stubs for skb_ext_add() and skb_ext_find() to reduce the > amount of ifdef-ery. (Jakub) It makes sense, good idea! Thank you for the new version! > --- linux-next-20201113.orig/include/linux/skbuff.h > +++ linux-next-20201113/include/linux/skbuff.h > @@ -4137,7 +4137,6 @@ static inline void skb_set_nfct(struct s > #endif > } > > -#ifdef CONFIG_SKB_EXTENSIONS > enum skb_ext_id { > #if IS_ENABLED(CONFIG_BRIDGE_NETFILTER) > SKB_EXT_BRIDGE_NF, > @@ -4151,12 +4150,11 @@ enum skb_ext_id { > #if IS_ENABLED(CONFIG_MPTCP) > SKB_EXT_MPTCP, > #endif > -#if IS_ENABLED(CONFIG_KCOV) > SKB_EXT_KCOV_HANDLE, > -#endif I don't think we should remove this #ifdef: the number of extensions are currently limited to 8, we might not want to always have KCOV there even if we don't want it. I think adding items in this enum only when needed was the intension of Florian (+cc) when creating these SKB extensions. Also, this will increase a tiny bit some structures, see "struct skb_ext()". But apart from that, I think we are fine, even if we add new extensions in the future after this kcov one. So if we think it is better to remove these #ifdef here, we should be OK. But if we prefer not to do that, we should then not add stubs for skb_ext_{add,find}() and keep the ones for skb_[gs]et_kcov_handle(). Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net