From: Valentin Schneider <valentin.schneider@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
mingo@kernel.org, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com,
cai@redhat.com, vincent.donnefort@arm.com, decui@microsoft.com,
paulmck@kernel.org, vincent.guittot@linaro.org,
rostedt@goodmis.org, tj@kernel.org, peterz@infradead.org
Subject: Re: [PATCH 3/4] workqueue: Tag bound workers with KTHREAD_IS_PER_CPU
Date: Tue, 12 Jan 2021 17:57:23 +0000 [thread overview]
Message-ID: <jhjy2gyyr5o.mognet@arm.com> (raw)
In-Reply-To: <20210112144843.849135905@infradead.org>
On 12/01/21 15:43, Peter Zijlstra wrote:
> @@ -4919,8 +4922,10 @@ static void unbind_workers(int cpu)
>
> raw_spin_unlock_irq(&pool->lock);
>
> - for_each_pool_worker(worker, pool)
> + for_each_pool_worker(worker, pool) {
> + kthread_set_per_cpu(worker->task, false);
> WARN_ON_ONCE(set_cpus_allowed_ptr(worker->task, cpu_possible_mask) < 0);
> + }
Doesn't this supersede patch 1? With patch 4 on top, the BALANCE_PUSH
stuff should start resetting the affinity of the kworkers for which we
are removing the IS_PER_CPU flag.
It's the only nit I have, the rest looks good to me so:
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
I'll go frob that sched_cpu_dying() warning.
next prev parent reply other threads:[~2021-01-12 17:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 14:43 [PATCH 0/4] sched: Fix hot-unplug regressions Peter Zijlstra
2021-01-12 14:43 ` [PATCH 2/4] kthread: Extract KTHREAD_IS_PER_CPU Peter Zijlstra
2021-01-12 14:43 ` [PATCH 3/4] workqueue: Tag bound workers with KTHREAD_IS_PER_CPU Peter Zijlstra
2021-01-12 16:36 ` Lai Jiangshan
2021-01-13 11:43 ` Peter Zijlstra
2021-01-12 17:57 ` Valentin Schneider [this message]
2021-01-13 13:28 ` Lai Jiangshan
2021-01-13 14:16 ` Valentin Schneider
2021-01-13 17:52 ` Paul E. McKenney
2021-01-13 18:43 ` Valentin Schneider
2021-01-13 18:59 ` Paul E. McKenney
2021-01-14 13:12 ` Peter Zijlstra
2021-01-14 13:21 ` Valentin Schneider
2021-01-14 15:34 ` Peter Zijlstra
2021-01-16 6:27 ` Lai Jiangshan
2021-01-16 12:45 ` Peter Zijlstra
2021-01-16 14:45 ` Lai Jiangshan
2021-01-16 15:16 ` Peter Zijlstra
2021-01-16 16:14 ` Lai Jiangshan
2021-01-16 18:46 ` Peter Zijlstra
2021-01-17 9:54 ` Peter Zijlstra
2021-01-16 15:13 ` Peter Zijlstra
2021-01-12 14:43 ` [PATCH 4/4] sched: Fix CPU hotplug / tighten is_per_cpu_kthread() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhjy2gyyr5o.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=cai@redhat.com \
--cc=decui@microsoft.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).