From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE11C432BE for ; Fri, 20 Aug 2021 04:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5064F60F8F for ; Fri, 20 Aug 2021 04:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232571AbhHTEcd (ORCPT ); Fri, 20 Aug 2021 00:32:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhHTEcc (ORCPT ); Fri, 20 Aug 2021 00:32:32 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3E96C061575 for ; Thu, 19 Aug 2021 21:31:54 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id y190so7535143pfg.7 for ; Thu, 19 Aug 2021 21:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=kGUsXVjhYVNqqDUplUqGfaMv9a3sMzZvTTWSgXAKeoA=; b=vysr45wmx6bUrXF0N/a2X2lB6TLNMruSRTGPFJV/qeHb/7wLiD/NnDnckqkgw8ag9L er9i67FuRz37SrgS4x3Lc6pdZrdH6z3JyJ2tUzuAKZWCUDu86DUbWD8T9InE30hGWdpv LmSavBQepWO20MenUktfU5N5htBdN6E4djZP1D/qLSbhv3Tm9Mu1EvOWQIA9lQwpgO8v GCDumNLUm3X+kL5kEMatRRPkcEze+KkBDVtXpuU4S/ZFkUwflpQZFA06ZeYYS3usefSh SpAljBrSt7Qjo7XRH9XzSX/CcNzq4dsKDwR16DEY/EF/n3oypdljgFnoLtyQA6jp4OCH 6CYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=kGUsXVjhYVNqqDUplUqGfaMv9a3sMzZvTTWSgXAKeoA=; b=AVcRtE1061EhA8qmTPLzfIzSUmGIdRIupIIJOt7OspO99GP1I8wUgoG4tFMmmJAHjp jHnTHy5n3WkeI9yMlzuFqB9SorfUpnnGy64aKpm79seiaGwrGma55DetxHzvsugULHL9 eY2ppry8QShP6s5e2q8626jw/2G+hXNWrAmynj0PwKCiMr3OShdP6nZWE4gve08QpUBT hPr4P7mrEy5qdeeJgXhY0Zwu2ewm3yFPuKIqTagUrGpjB769UE1VAW0ic7KHzwRKk95c ux4iWo4TZCfbaM815wUNlzVhEmlkmV5T8dWAY0Dsy3DM/v6LD0mEtc0FISoQl3i4W5Vu yx+Q== X-Gm-Message-State: AOAM530pE1xQkBPSBKt5gCitBPxU+B3ceAtA+PcgxcGzBCfnzMZoRNqk AxbWZHpqrUked69Y12TyuEKFsQ== X-Google-Smtp-Source: ABdhPJyS1DqIzxR93iVwZIP2G0nZomzW8c6Lq4fpfYaMPWsqFpt79VvtUo0LKUPICC7P9n/ka3YrGw== X-Received: by 2002:a63:4005:: with SMTP id n5mr16785065pga.140.1629433914057; Thu, 19 Aug 2021 21:31:54 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id a8sm5131173pfo.79.2021.08.19.21.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 21:31:53 -0700 (PDT) Date: Thu, 19 Aug 2021 21:31:53 -0700 (PDT) X-Google-Original-Date: Thu, 19 Aug 2021 20:55:39 PDT (-0700) Subject: Re: [PATCH] dt-bindings: sifive-l2-cache: Fix 'select' matching In-Reply-To: <20210817174755.541735-1-robh@kernel.org> CC: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Walmsley , aou@eecs.berkeley.edu, sagar.kadam@sifive.com, yash.shah@sifive.com, linux-riscv@lists.infradead.org From: Palmer Dabbelt To: robh@kernel.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Aug 2021 10:47:55 PDT (-0700), robh@kernel.org wrote: > When the schema fixups are applied to 'select' the result is a single > entry is required for a match, but that will never match as there should > be 2 entries. Also, a 'select' schema should have the widest possible > match, so use 'contains' which matches the compatible string(s) in any > position and not just the first position. > > Fixes: 993dcfac64eb ("dt-bindings: riscv: sifive-l2-cache: convert bindings to json-schema") > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Sagar Kadam > Cc: Yash Shah > Cc: linux-riscv@lists.infradead.org > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/riscv/sifive-l2-cache.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml b/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml > index 1d38ff76d18f..2b1f91603897 100644 > --- a/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml > +++ b/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml > @@ -24,10 +24,10 @@ allOf: > select: > properties: > compatible: > - items: > - - enum: > - - sifive,fu540-c000-ccache > - - sifive,fu740-c000-ccache > + contains: > + enum: > + - sifive,fu540-c000-ccache > + - sifive,fu740-c000-ccache > > required: > - compatible Thanks, this is on fixes.