From: Palmer Dabbelt <palmerdabbelt@google.com>
To: wangkefeng.wang@huawei.com
Cc: wangliang101@huawei.com, mcgrof@kernel.org,
linux-kernel@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
stable@vger.kernel.org, wangle6@huawei.com,
kepler.chenxin@huawei.com, nixiaoming@huawei.com
Subject: Re: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed()
Date: Tue, 03 Aug 2021 17:20:00 -0700 (PDT) [thread overview]
Message-ID: <mhng-e101fb5a-2f16-45a0-8436-454ac2bf4223@palmerdabbelt-glaptop> (raw)
In-Reply-To: <12e37243-0cdb-6765-c3ef-c98fd291591c@huawei.com>
On Fri, 30 Jul 2021 00:04:05 PDT (-0700), wangkefeng.wang@huawei.com wrote:
>
> On 2021/7/30 14:49, Liang Wang wrote:
>> The physical address may exceed 32 bits on ARM(when ARM_LPAE enabled),
>> use PFN_PHYS() in devmem_is_allowed(), or the physical address may
>> overflow and be truncated.
>>
>> This bug was initially introduced from v2.6.37, and the function was moved
>> to lib when v5.10.
>>
>> Fixes: 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
>> Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
>> Cc: stable@vger.kernel.org # v2.6.37
>> Signed-off-by: Liang Wang <wangliang101@huawei.com>
> Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> v2: update subject and changelog
>> lib/devmem_is_allowed.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/devmem_is_allowed.c b/lib/devmem_is_allowed.c
>> index c0d67c541849..60be9e24bd57 100644
>> --- a/lib/devmem_is_allowed.c
>> +++ b/lib/devmem_is_allowed.c
>> @@ -19,7 +19,7 @@
>> */
>> int devmem_is_allowed(unsigned long pfn)
>> {
>> - if (iomem_is_exclusive(pfn << PAGE_SHIFT))
>> + if (iomem_is_exclusive(PFN_PHYS(pfn)))
>> return 0;
>> if (!page_is_ram(pfn))
>> return 1;
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
I only see the reply so I'm assuming this is going in through some other
tree, but LMK if you want it via the RISC-V tree as IIRC we're using it
too.
Thanks!
next prev parent reply other threads:[~2021-08-04 0:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210730064915.56249-1-wangliang101@huawei.com>
2021-07-30 7:04 ` [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed() Kefeng Wang
2021-08-04 0:20 ` Palmer Dabbelt [this message]
2021-08-04 5:03 ` Kefeng Wang
2021-07-30 7:43 Liang Wang
2021-07-30 19:36 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-e101fb5a-2f16-45a0-8436-454ac2bf4223@palmerdabbelt-glaptop \
--to=palmerdabbelt@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kepler.chenxin@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcgrof@kernel.org \
--cc=nixiaoming@huawei.com \
--cc=stable@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=wangle6@huawei.com \
--cc=wangliang101@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).