From: Andreas Schwab <schwab@suse.de>
To: Yash Shah <yash.shah@sifive.com>
Cc: "linus.walleij\@linaro.org" <linus.walleij@linaro.org>,
"bgolaszewski\@baylibre.com" <bgolaszewski@baylibre.com>,
"robh+dt\@kernel.org" <robh+dt@kernel.org>,
"mark.rutland\@arm.com" <mark.rutland@arm.com>,
"palmer\@dabbelt.com" <palmer@dabbelt.com>,
"Paul Walmsley \( Sifive\)" <paul.walmsley@sifive.com>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
"aou\@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"jason\@lakedaemon.net" <jason@lakedaemon.net>,
"linux-gpio\@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"maz\@kernel.org" <maz@kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"atish.patra\@wdc.com" <atish.patra@wdc.com>,
Sagar Kadam <sagar.kadam@sifive.com>,
"tglx\@linutronix.de" <tglx@linutronix.de>,
"bmeng.cn\@gmail.com" <bmeng.cn@gmail.com>,
"linux-riscv\@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Sachin Ghadi <sachin.ghadi@sifive.com>
Subject: Re: [PATCH v2 5/5] riscv: dts: Add DT support for SiFive FU540 GPIO driver
Date: Wed, 20 Nov 2019 10:14:00 +0100 [thread overview]
Message-ID: <mvmlfsaoqp3.fsf@suse.de> (raw)
In-Reply-To: <1574233128-28114-6-git-send-email-yash.shah@sifive.com> (Yash Shah's message of "Wed, 20 Nov 2019 06:59:54 +0000")
On Nov 20 2019, Yash Shah wrote:
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 88cfcb9..609198c 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -94,3 +94,7 @@
> &pwm1 {
> status = "okay";
> };
> +
> +&gpio {
> + status = "okay";
> +};
How about adding a gpio-restart?
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2019-11-20 9:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 6:59 [PATCH v2 0/5] GPIO & Hierarchy IRQ support for HiFive Unleashed Yash Shah
2019-11-20 6:59 ` [PATCH v2 1/5] genirq: introduce irq_domain_translate_onecell Yash Shah
2019-11-20 9:34 ` Thomas Gleixner
2019-11-20 10:24 ` Marc Zyngier
2019-11-20 10:48 ` Thomas Gleixner
2019-11-20 10:38 ` Marc Zyngier
2019-11-21 8:35 ` Yash Shah
2019-11-21 8:55 ` Yash Shah
2019-11-21 9:20 ` Marc Zyngier
2019-11-20 6:59 ` [PATCH v2 2/5] irqchip: sifive: Support hierarchy irq domain Yash Shah
2019-11-22 10:17 ` Marc Zyngier
2019-11-20 6:59 ` [PATCH v2 3/5] gpio: sifive: Add DT documentation for SiFive GPIO Yash Shah
2019-11-20 6:59 ` [PATCH v2 4/5] gpio: sifive: Add GPIO driver for SiFive SoCs Yash Shah
2019-11-20 10:01 ` Bartosz Golaszewski
2019-11-21 8:32 ` Yash Shah
2019-11-20 6:59 ` [PATCH v2 5/5] riscv: dts: Add DT support for SiFive FU540 GPIO driver Yash Shah
2019-11-20 9:14 ` Andreas Schwab [this message]
2019-11-21 8:26 ` Yash Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmlfsaoqp3.fsf@suse.de \
--to=schwab@suse.de \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=bgolaszewski@baylibre.com \
--cc=bmeng.cn@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=sagar.kadam@sifive.com \
--cc=tglx@linutronix.de \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).