linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: "Kamil Domański" <kamil@domanski.co>
Cc: linux-kernel@vger.kernel.org,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Nestor Lopez Casado" <nlopezcasad@logitech.com>,
	"Filipe Laíns" <lains@archlinux.org>
Subject: Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset
Date: Mon, 31 Aug 2020 09:00:39 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2008310859340.27422@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200704004745.383271-1-kamil@domanski.co>

On Sat, 4 Jul 2020, Kamil Domański wrote:

> Changelog:
>   v2:
>   - changed charging status parsing to account for invalid states
>   v3:
>   - rebased against Linux v5.7
>   - changed variable naming in hidpp20_adc_map_status_voltage
>     to camel case
>   - corrected comment styling in hidpp_battery_get_property
>   - dropped usage of test_bit macro in hidpp20_adc_map_status_voltage
>     to avoid using `long` type
>   - added bit flag definitions in hidpp20_adc_map_status_voltage
> 
> Signed-off-by: Kamil Domański <kamil@domanski.co>

Hi,

I've finally made it to this patch (sorry for the delay), and it looks 
good to me in general (no major concerns with the polling either).

Could you please send me the proper changelog that should go to the 
commitlog though (it's definitely not this 'Changes sice vX ...').

Thanks,

-- 
Jiri Kosina
SUSE Labs


  parent reply	other threads:[~2020-08-31  7:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-04  0:47 [PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset Kamil Domański
2020-07-04 15:01 ` Filipe Laíns
2020-08-31  7:00 ` Jiri Kosina [this message]
     [not found]   ` <CA+oAjKzdmzg2KFuuSOJL35ifHRSCosHW+y4Cm4bmQQQc49GjAA@mail.gmail.com>
2020-09-25 11:48     ` Jiri Kosina
  -- strict thread matches above, loose matches on Subject: below --
2020-07-04  0:43 Kamil Domański

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2008310859340.27422@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=kamil@domanski.co \
    --cc=lains@archlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nlopezcasad@logitech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).