From: Jiri Kosina <jikos@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: Use 'atomic_inc_return' instead of hand-writing it
Date: Fri, 20 Aug 2021 14:21:05 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2108201420570.15313@cbobk.fhfr.pm> (raw)
In-Reply-To: <1091bc38881086be28d561adca042caba234f3f2.1627054657.git.christophe.jaillet@wanadoo.fr>
On Fri, 23 Jul 2021, Christophe JAILLET wrote:
> This function logs a warning if the workqueue gets too big.
> In order to save a few cycles, use 'atomic_inc_return()' instead of an
> 'atomic_inc()/atomic_read()' sequence.
>
> This axes a line of code and saves a 'atomic_read()' call.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/hid/hid-logitech-hidpp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index 61635e629469..a7fa35245c2e 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -2240,11 +2240,10 @@ static int hidpp_ff_queue_work(struct hidpp_ff_private_data *data, int effect_id
> wd->size = size;
> memcpy(wd->params, params, size);
>
> - atomic_inc(&data->workqueue_size);
> + s = atomic_inc_return(&data->workqueue_size);
> queue_work(data->wq, &wd->work);
>
> /* warn about excessive queue size */
> - s = atomic_read(&data->workqueue_size);
> if (s >= 20 && s % 20 == 0)
> hid_warn(data->hidpp->hid_dev, "Force feedback command queue contains %d commands, causing substantial delays!", s);
Applied, thank you.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-08-20 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 15:41 [PATCH] HID: logitech-hidpp: Use 'atomic_inc_return' instead of hand-writing it Christophe JAILLET
2021-08-20 12:21 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2108201420570.15313@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).