From: Jiri Kosina <jikos@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>,
"Ping Cheng" <pinglinux@gmail.com>,
"Aaron Armstrong Skomra" <skomra@gmail.com>,
"Jason Gerecke" <killertofu@gmail.com>,
"Peter Hutterer" <peter.hutterer@who-t.net>,
linux-input@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/12] HID: fix for generic input processing
Date: Tue, 1 Mar 2022 15:53:31 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2203011552560.24795@cbobk.fhfr.pm> (raw)
In-Reply-To: <20220203143226.4023622-1-benjamin.tissoires@redhat.com>
On Thu, 3 Feb 2022, Benjamin Tissoires wrote:
> Hi,
>
> this is the v2 of my series which reworks the HID report processing.
>
> I took Ping's comments into account, and amended my MR with the
> regression tests[0].
> More specifically, the tests (and thus this new version of the series)
> enforces that only one BTN_TOOL_* event gets forwarded between each
> EV_SYN frame, and that BTN_TOUCH are properly translated too.
>
> This also magivally solved some worrying transitions we had in the
> pen state machine where the pen was jumping from "eraser" to "in
> contact". This new behavior enforces a "out-of-range" state in the
> middle, making it easier for userspace to understand now.
>
> Again, tests are welcome :)
>
> Cheers,
> Benjamin
>
> [0] https://gitlab.freedesktop.org/libevdev/hid-tools/-/merge_requests/127
>
> Benjamin Tissoires (12):
> HID: core: statically allocate read buffers
> HID: core: de-duplicate some code in hid_input_field()
> HID: core: split data fetching from processing in hid_input_field()
> HID: input: tag touchscreens as such if the physical is not there
> HID: input: rework spaghetti code with switch statements
> HID: input: move up out-of-range processing of input values
> HID: compute an ordered list of input fields to process
> HID: core: for input reports, process the usages by priority list
> HID: input: enforce Invert usage to be processed before InRange
> HID: input: remove the need for HID_QUIRK_INVERT
> HID: input: accommodate priorities for slotted devices
> Input: docs: add more details on the use of BTN_TOOL
>
> Documentation/input/event-codes.rst | 6 +-
> drivers/hid/hid-core.c | 280 ++++++++++++++++++---
> drivers/hid/hid-input.c | 364 ++++++++++++++++++++++------
> include/linux/hid.h | 23 +-
> 4 files changed, 568 insertions(+), 105 deletions(-)
This is now in hid.git#for-5.18/core.
Thanks a lot Benjamin, very nice work.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2022-03-01 14:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 14:32 [PATCH v2 00/12] HID: fix for generic input processing Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 01/12] HID: core: statically allocate read buffers Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 02/12] HID: core: de-duplicate some code in hid_input_field() Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 03/12] HID: core: split data fetching from processing " Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 04/12] HID: input: tag touchscreens as such if the physical is not there Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 05/12] HID: input: rework spaghetti code with switch statements Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 06/12] HID: input: move up out-of-range processing of input values Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 07/12] HID: compute an ordered list of input fields to process Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 08/12] HID: core: for input reports, process the usages by priority list Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 09/12] HID: input: enforce Invert usage to be processed before InRange Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 10/12] HID: input: remove the need for HID_QUIRK_INVERT Benjamin Tissoires
2022-02-04 1:41 ` Ping Cheng
2022-02-10 5:21 ` Ping Cheng
2022-02-10 5:43 ` Ping Cheng
2022-02-14 10:23 ` Benjamin Tissoires
2022-02-15 2:04 ` Ping Cheng
2022-02-15 8:51 ` Benjamin Tissoires
2022-02-16 12:42 ` Benjamin Tissoires
2022-02-17 1:27 ` Ping Cheng
2022-02-03 14:32 ` [PATCH v2 11/12] HID: input: accommodate priorities for slotted devices Benjamin Tissoires
2022-02-03 14:32 ` [PATCH v2 12/12] Input: docs: add more details on the use of BTN_TOOL Benjamin Tissoires
2022-02-16 5:40 ` Peter Hutterer
2022-03-01 14:53 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2203011552560.24795@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=killertofu@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=peter.hutterer@who-t.net \
--cc=pinglinux@gmail.com \
--cc=skomra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).