From: Nicolas Pitre <nico@fluxnic.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>,
Or Cohen <orcohen@paloaltonetworks.com>,
textshell@uchuujin.de, Daniel Vetter <daniel.vetter@ffwll.ch>,
sam@ravnborg.org, mpatocka@redhat.com, ghalat@redhat.com,
linux-kernel@vger.kernel.org, jwilk@jwilk.net,
Nadav Markus <nmarkus@paloaltonetworks.com>,
syzkaller@googlegroups.com
Subject: Re: Bug report - slab-out-of-bounds in vcs_scr_readw
Date: Tue, 26 Nov 2019 16:55:32 -0500 (EST) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1911261652290.8537@knanqh.ubzr> (raw)
In-Reply-To: <nycvar.YSQ.7.76.1911051030580.30289@knanqh.ubzr>
Greg, could you apply this please?
On Tue, 5 Nov 2019, Nicolas Pitre wrote:
> Subject: [PATCH] vcs: prevent write access to vcsu devices
>
> Commit d21b0be246bf ("vt: introduce unicode mode for /dev/vcs") guarded
> against using devices containing attributes as this is not yet
> implemented. It however failed to guard against writes to any devices
> as this is also unimplemented.
>
> Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
> Cc: <stable@vger.kernel.org> # v4.19+
>
> diff --git a/drivers/tty/vt/vc_screen.c b/drivers/tty/vt/vc_screen.c
> index fa07d79027..ef19b95b73 100644
> --- a/drivers/tty/vt/vc_screen.c
> +++ b/drivers/tty/vt/vc_screen.c
> @@ -456,6 +456,9 @@ vcs_write(struct file *file, const char __user *buf, size_t count, loff_t *ppos)
> size_t ret;
> char *con_buf;
>
> + if (use_unicode(inode))
> + return -EOPNOTSUPP;
> +
> con_buf = (char *) __get_free_page(GFP_KERNEL);
> if (!con_buf)
> return -ENOMEM;
>
>
next prev parent reply other threads:[~2019-11-26 21:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAM6JnLeEnvjjQPyLeh+8dt5wGNud_vks5k_eXJZy2T1H7ao=hQ@mail.gmail.com>
2019-11-04 15:24 ` Bug report - slab-out-of-bounds in vcs_scr_readw Greg KH
2019-11-04 15:50 ` Nicolas Pitre
2019-11-04 16:15 ` Or Cohen
2019-11-04 18:33 ` Nicolas Pitre
2019-11-05 6:54 ` Jiri Slaby
2019-11-05 9:03 ` Or Cohen
2019-11-05 9:14 ` Jiri Slaby
2019-11-05 9:33 ` Nicolas Pitre
2019-11-05 10:29 ` Jiri Slaby
2019-11-05 10:53 ` Dmitry Vyukov
2019-11-05 13:44 ` Nicolas Pitre
2019-11-06 17:01 ` Or Cohen
2019-11-26 21:55 ` Nicolas Pitre [this message]
2019-11-27 6:45 ` Greg KH
2019-11-27 16:24 ` Nicolas Pitre
2019-11-27 16:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1911261652290.8537@knanqh.ubzr \
--to=nico@fluxnic.net \
--cc=daniel.vetter@ffwll.ch \
--cc=ghalat@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=jwilk@jwilk.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=nmarkus@paloaltonetworks.com \
--cc=orcohen@paloaltonetworks.com \
--cc=sam@ravnborg.org \
--cc=syzkaller@googlegroups.com \
--cc=textshell@uchuujin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).