From: Takashi Iwai <tiwai@suse.de>
To: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Cc: alsa-devel@alsa-project.org, bp@alien8.de, hch@infradead.org,
Christoph Hellwig <hch@lst.de>,
hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@redhat.com,
Pavel Machek <pavel@ucw.cz>,
perex@perex.cz, rientjes@google.com, tglx@linutronix.de,
tiwai@suse.com, x86@kernel.org
Subject: Re: next-0519 on thinkpad x60: sound related? window manager crash
Date: Thu, 11 Jun 2020 19:11:14 +0200 [thread overview]
Message-ID: <s5h8sgtede5.wl-tiwai@suse.de> (raw)
In-Reply-To: <1591885264.uk6f214o4o.none@localhost>
On Thu, 11 Jun 2020 16:51:55 +0200,
Alex Xu (Hello71) wrote:
>
> Excerpts from Takashi Iwai's message of June 9, 2020 11:12 am:
> > On Tue, 09 Jun 2020 13:47:33 +0200,
> > Christoph Hellwig wrote:
> >>
> >> Alex, can you try this patch?
> >
> > Also could you check whether just papering over the memset() call
> > alone avoids the crash like below? For PulseAudio and dmix/dsnoop,
> > it's the only code path that accesses the vmapped buffer, I believe.
> >
> > If this works more or less, I'll cook a more comprehensive fix.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > --- a/sound/core/pcm_native.c
> > +++ b/sound/core/pcm_native.c
> > @@ -754,9 +754,11 @@ static int snd_pcm_hw_params(struct snd_pcm_substream *substream,
> > while (runtime->boundary * 2 <= LONG_MAX - runtime->buffer_size)
> > runtime->boundary *= 2;
> >
> > +#if 0
> > /* clear the buffer for avoiding possible kernel info leaks */
> > if (runtime->dma_area && !substream->ops->copy_user)
> > memset(runtime->dma_area, 0, runtime->dma_bytes);
> > +#endif
> >
> > snd_pcm_timer_resolution_change(substream);
> > snd_pcm_set_state(substream, SNDRV_PCM_STATE_SETUP);
> >
>
> Sorry, this patch doesn't work for me with SME off using abfbb29297c2.
> David's newest submitted patch works for me, which I already replied to
> separately.
Thanks, so something still missing in the mmap handling, I guess.
I've worked on two different branches for potential fixes of your
problems. Could you test topic/dma-fix and topic/dma-fix2 branches?
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
Just pull one of them onto Linus' git HEAD.
I guess we'll go with David's new patch, but still it's interesting
whether my changes do anything good actually.
Takashi
next prev parent reply other threads:[~2020-06-11 17:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 11:11 next-0519 on thinkpad x60: sound related? window manager crash Pavel Machek
2020-05-20 11:37 ` Takashi Iwai
2020-05-20 11:39 ` Pavel Machek
2020-05-20 11:43 ` Takashi Iwai
2020-06-07 15:58 ` Alex Xu (Hello71)
2020-06-07 16:38 ` 82fef0ad811f "x86/mm: unencrypted non-blocking DMA allocations use coherent pools" was " Pavel Machek
2020-06-07 19:41 ` David Rientjes
2020-06-07 22:53 ` Alex Xu (Hello71)
2020-06-08 0:57 ` David Rientjes
2020-06-08 2:13 ` Alex Xu (Hello71)
2020-06-08 6:19 ` Christoph Hellwig
2020-06-08 13:53 ` Alex Xu (Hello71)
2020-06-09 2:31 ` David Rientjes
2020-06-09 5:43 ` Christoph Hellwig
2020-06-09 8:05 ` Takashi Iwai
2020-06-09 8:43 ` Christoph Hellwig
2020-06-09 9:09 ` Takashi Iwai
2020-06-09 9:17 ` Christoph Hellwig
2020-06-09 9:31 ` Takashi Iwai
2020-06-09 11:02 ` Takashi Iwai
2020-06-09 11:31 ` Christoph Hellwig
2020-06-09 11:38 ` Takashi Iwai
2020-06-09 11:40 ` Christoph Hellwig
2020-06-09 11:45 ` Takashi Iwai
2020-06-09 11:49 ` Christoph Hellwig
2020-06-09 13:16 ` Jaroslav Kysela
2020-06-10 5:26 ` David Rientjes
2020-06-10 7:14 ` Christoph Hellwig
2020-06-09 11:47 ` Christoph Hellwig
2020-06-09 15:12 ` Takashi Iwai
[not found] ` <<s5hr1uogtna.wl-tiwai@suse.de>
2020-06-11 14:51 ` Alex Xu (Hello71)
2020-06-11 17:11 ` Takashi Iwai [this message]
2020-06-13 16:25 ` Alex Xu (Hello71)
2020-06-14 9:54 ` Takashi Iwai
2020-06-14 12:07 ` Alex Xu (Hello71)
2020-06-14 15:40 ` Takashi Iwai
2020-06-11 14:51 ` Alex Xu (Hello71)
[not found] <20200520110900.GA8203@amd>
2020-05-21 7:41 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8sgtede5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alex_y_xu@yahoo.ca \
--cc=alsa-devel@alsa-project.org \
--cc=bp@alien8.de \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).