From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C72C433FE for ; Sun, 12 Dec 2021 08:58:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbhLLI6e (ORCPT ); Sun, 12 Dec 2021 03:58:34 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:56938 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbhLLI6d (ORCPT ); Sun, 12 Dec 2021 03:58:33 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id DBA241F3AC; Sun, 12 Dec 2021 08:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1639299511; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RdQERHM96yBBje3WLQrA2u2xMGiyCJwJHqviZnXvKlY=; b=SRDdQrTHKUFY1dasR0do6uLLHNl0S2oR4XOYwu8ppoYOjCkAqOXC4uR+XnvJwIMkLvVhyz GM0ACvzUEyxAxWFIHjLMpjd8XCJXzrhHRLM6fOn+Wde1sJSMO6SMpshLZQryTd6hBYaQfJ Tw3FiLkbcBuT/LXZdFPVPRcZx5W4x0Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1639299511; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RdQERHM96yBBje3WLQrA2u2xMGiyCJwJHqviZnXvKlY=; b=EKWma8HOpEuFSxv1dXTn0Fsq+UMd5n3dIZUReSjHYmrehd1DRPLRYL6ziXIu0ZFU5dpYeJ ioFzMLoIOPv5qVBw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3C972A3B81; Sun, 12 Dec 2021 08:58:31 +0000 (UTC) Date: Sun, 12 Dec 2021 09:58:31 +0100 Message-ID: From: Takashi Iwai To: Bradley Scott Cc: Jaroslav Kysela , Takashi Iwai , Jonathan Corbet , Jeremy Szu , Hui Wang , Werner Sembach , Kailang Yang , Cameron Berkenpas , Sami Loone , Elia Devito , alsa-devel@alsa-project.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Amp init fixup for HP ZBook 15 G6 In-Reply-To: <20211210192614.460529-1-Bradley.Scott@zebra.com> References: <20211210192614.460529-1-Bradley.Scott@zebra.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Dec 2021 20:26:12 +0100, Bradley Scott wrote: > > HP ZBook 15 G6 (SSID 103c:860f) needs the same speaker amplifier > initialization as used on several other HP laptops using ALC285. > > This commit also adds a new "alc285-hp-amp-init" model that can be used > to apply this same amp init fixup to other devices by passing > "hda_model=alc285-hp-amp-init" to the snd-sof-intel-hda-common module or > "model=alc285-hp-amp-init" to the snd-hda-intel module, depending on > which is being used. > > Signed-off-by: Bradley Scott Thanks for the patch. Unfortunately, somehow your MUA broke the tabs with spaces and the patch wasn't cleanly applicable. Also, I prefer splitting the changes to two, the addition of a quirk entry and the addition to the model string. Then old stable kernels have more chance to pick up. Could you try to resubmit? In the worst case, I can take the attachments, too. Takashi