From: Takashi Iwai <tiwai@suse.de>
To: Sameer Pujar <spujar@nvidia.com>
Cc: <broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
<tiwai@suse.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <alsa-devel@alsa-project.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/16] Kcontrol get/put cleanup in Tegra drivers
Date: Thu, 18 Nov 2021 14:33:50 +0100 [thread overview]
Message-ID: <s5hy25lio5d.wl-tiwai@suse.de> (raw)
In-Reply-To: <1637219231-406-1-git-send-email-spujar@nvidia.com>
On Thu, 18 Nov 2021 08:06:55 +0100,
Sameer Pujar wrote:
>
> There are two cleanups in the series:
> 1. Use correct value type for enum controls. This is suggested by
> Takashi during review of v2.
>
> 2. This series fixes kcontrol put callback in some of the Tegra drivers
> which are used on platforms based on Tegra210 and later. The callback
> is expected to return 1 whenever the HW update is done.
>
> This idea is suggested by Jaroslav. Similar suggestion came from
> Mark during review of series [0] and drivers under this were updated
> to return 1, but missed to take care of duplicate updates. This series
> updates all concerned drivers to return proper values and duplicate
> updates are filtered out.
>
> I have added 'Suggested-by" tags accordingly.
>
> [0] https://lore.kernel.org/linux-arm-kernel/20210913142307.GF4283@sirena.org.uk/
>
> Changelog
> =========
> v2->v3:
> -------
> * Add fixes related to wrong value type as suggested by Takashi.
> Relevant drivers are updated as part of it.
>
> * Use separate get/put callbacks for each mixer control. The common
> part is pushed to separate function wherever applicable, thus
> removing usage of strstr() calls. The return values are fixed
> as suggested.
>
>
> v1->v2:
> -------
> * ADMAIF, I2S, DMIC and DSPK drivers updated to take care of
> duplicate updates.
> * Similarly new patches are added for AHUB, MVC, SFC, AMX, ADX
> and Mixer drivers.
>
> Sameer Pujar (16):
> ASoC: tegra: Fix wrong value type in ADMAIF
> ASoC: tegra: Fix wrong value type in I2S
> ASoC: tegra: Fix wrong value type in DMIC
> ASoC: tegra: Fix wrong value type in DSPK
> ASoC: tegra: Fix wrong value type in SFC
> ASoC: tegra: Fix wrong value type in MVC
> ASoC: tegra: Fix kcontrol put callback in ADMAIF
> ASoC: tegra: Fix kcontrol put callback in I2S
> ASoC: tegra: Fix kcontrol put callback in DMIC
> ASoC: tegra: Fix kcontrol put callback in DSPK
> ASoC: tegra: Fix kcontrol put callback in AHUB
> ASoC: tegra: Fix kcontrol put callback in MVC
> ASoC: tegra: Fix kcontrol put callback in SFC
> ASoC: tegra: Fix kcontrol put callback in AMX
> ASoC: tegra: Fix kcontrol put callback in ADX
> ASoC: tegra: Fix kcontrol put callback in Mixer
Through a quick glance, the series looks good to me. One place could
be more optimized with a regmap helper, but it's a minor issue and can
be updated later, too.
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
next prev parent reply other threads:[~2021-11-18 13:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 7:06 [PATCH v3 00/16] Kcontrol get/put cleanup in Tegra drivers Sameer Pujar
2021-11-18 7:06 ` [PATCH v3 01/16] ASoC: tegra: Fix wrong value type in ADMAIF Sameer Pujar
2021-11-18 7:06 ` [PATCH v3 02/16] ASoC: tegra: Fix wrong value type in I2S Sameer Pujar
2021-11-18 7:06 ` [PATCH v3 03/16] ASoC: tegra: Fix wrong value type in DMIC Sameer Pujar
2021-11-18 7:06 ` [PATCH v3 04/16] ASoC: tegra: Fix wrong value type in DSPK Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 05/16] ASoC: tegra: Fix wrong value type in SFC Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 06/16] ASoC: tegra: Fix wrong value type in MVC Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 07/16] ASoC: tegra: Fix kcontrol put callback in ADMAIF Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 08/16] ASoC: tegra: Fix kcontrol put callback in I2S Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 09/16] ASoC: tegra: Fix kcontrol put callback in DMIC Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 10/16] ASoC: tegra: Fix kcontrol put callback in DSPK Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 11/16] ASoC: tegra: Fix kcontrol put callback in AHUB Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 12/16] ASoC: tegra: Fix kcontrol put callback in MVC Sameer Pujar
2021-11-18 13:32 ` Takashi Iwai
2021-11-18 13:49 ` Mark Brown
2021-11-18 7:07 ` [PATCH v3 13/16] ASoC: tegra: Fix kcontrol put callback in SFC Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 14/16] ASoC: tegra: Fix kcontrol put callback in AMX Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 15/16] ASoC: tegra: Fix kcontrol put callback in ADX Sameer Pujar
2021-11-18 7:07 ` [PATCH v3 16/16] ASoC: tegra: Fix kcontrol put callback in Mixer Sameer Pujar
2021-11-18 13:33 ` Takashi Iwai [this message]
2021-11-18 19:06 ` [PATCH v3 00/16] Kcontrol get/put cleanup in Tegra drivers Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy25lio5d.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).