linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Steve Lee <steves.lee@maximintegrated.com>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
	<tiwai@suse.com>, <ckeepax@opensource.cirrus.com>,
	<geert@linux-m68k.org>, <rf@opensource.wolfsonmicro.com>,
	<shumingf@realtek.com>, <srinivas.kandagatla@linaro.org>,
	<krzk@kernel.org>, <dmurphy@ti.com>, <jack.yu@realtek.com>,
	<nuno.sa@analog.com>, <linux-kernel@vger.kernel.org>,
	<alsa-devel@alsa-project.org>, <ryan.lee.maxim@gmail.com>,
	<ryans.lee@maximintegrated.com>, <steves.lee.maxim@gmail.com>
Subject: Re: [PATCH] ASoC: max98390: Fix potential crash during param fw loading
Date: Wed, 03 Jun 2020 13:24:08 +0200	[thread overview]
Message-ID: <s5hzh9kcrzb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200603111819.5824-1-steves.lee@maximintegrated.com>

On Wed, 03 Jun 2020 13:18:19 +0200,
Steve Lee wrote:
> 
> @@ -847,7 +861,6 @@ static int max98390_probe(struct snd_soc_component *component)
>  
>  	/* Dsm Setting */
>  	regmap_write(max98390->regmap, DSM_VOL_CTRL, 0x94);
> -	regmap_write(max98390->regmap, DSMIG_EN, 0x19);

Is this change intentional?
It wasn't mentioned in the patch description.


thanks,

Takashi

  reply	other threads:[~2020-06-03 11:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 11:18 [PATCH] ASoC: max98390: Fix potential crash during param fw loading Steve Lee
2020-06-03 11:24 ` Takashi Iwai [this message]
2020-06-03 11:30   ` Steve Lee
2020-06-03 11:31 ` Mark Brown
2020-06-03 11:37   ` Steve Lee
2020-06-03 11:42     ` Mark Brown
2020-06-03 23:48       ` Steve Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hzh9kcrzb.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=dmurphy@ti.com \
    --cc=geert@linux-m68k.org \
    --cc=jack.yu@realtek.com \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.wolfsonmicro.com \
    --cc=ryan.lee.maxim@gmail.com \
    --cc=ryans.lee@maximintegrated.com \
    --cc=shumingf@realtek.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=steves.lee.maxim@gmail.com \
    --cc=steves.lee@maximintegrated.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).