From: tip-bot for Kees Cook <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: keescook@chromium.org, linux-kernel@vger.kernel.org,
hpa@zytor.com, peterz@infradead.org, jpoimboe@redhat.com,
tglx@linutronix.de, mingo@kernel.org,
torvalds@linux-foundation.org, elena.reshetova@intel.com
Subject: [tip:locking/core] locking/refcount: Remove the half-implemented refcount_sub() API
Date: Sun, 2 Jul 2017 02:28:02 -0700 [thread overview]
Message-ID: <tip-5d6dec6fba38c3e2d408df108bb92ef4ac201f18@git.kernel.org> (raw)
In-Reply-To: <20170701180129.GA17405@beast>
Commit-ID: 5d6dec6fba38c3e2d408df108bb92ef4ac201f18
Gitweb: http://git.kernel.org/tip/5d6dec6fba38c3e2d408df108bb92ef4ac201f18
Author: Kees Cook <keescook@chromium.org>
AuthorDate: Sat, 1 Jul 2017 11:01:29 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Sun, 2 Jul 2017 11:24:36 +0200
locking/refcount: Remove the half-implemented refcount_sub() API
CONFIG_REFCOUNT_FULL=y (correctly) does not provide a refcount_sub(),
which should not be part of proper refcount design patterns.
Remove the erroneous extern and the later !CONFIG_REFCOUNT_FULL
accidental implementation.
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Elena Reshetova <elena.reshetova@intel.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 29dee3c03abc ("locking/refcounts: Out-of-line everything")
Link: http://lkml.kernel.org/r/20170701180129.GA17405@beast
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
include/linux/refcount.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/include/linux/refcount.h b/include/linux/refcount.h
index bb71f28..591792c 100644
--- a/include/linux/refcount.h
+++ b/include/linux/refcount.h
@@ -49,7 +49,6 @@ extern __must_check bool refcount_inc_not_zero(refcount_t *r);
extern void refcount_inc(refcount_t *r);
extern __must_check bool refcount_sub_and_test(unsigned int i, refcount_t *r);
-extern void refcount_sub(unsigned int i, refcount_t *r);
extern __must_check bool refcount_dec_and_test(refcount_t *r);
extern void refcount_dec(refcount_t *r);
@@ -79,11 +78,6 @@ static inline __must_check bool refcount_sub_and_test(unsigned int i, refcount_t
return atomic_sub_and_test(i, &r->refs);
}
-static inline void refcount_sub(unsigned int i, refcount_t *r)
-{
- atomic_sub(i, &r->refs);
-}
-
static inline __must_check bool refcount_dec_and_test(refcount_t *r)
{
return atomic_dec_and_test(&r->refs);
prev parent reply other threads:[~2017-07-02 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 18:01 [PATCH] locking/refcounts: Remove refcount_sub() extern Kees Cook
2017-07-02 9:28 ` tip-bot for Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-5d6dec6fba38c3e2d408df108bb92ef4ac201f18@git.kernel.org \
--to=tipbot@zytor.com \
--cc=elena.reshetova@intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).