linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: peterz@infradead.org, jolsa@kernel.org, tglx@linutronix.de,
	acme@redhat.com, alexander.shishkin@linux.intel.com,
	mingo@kernel.org, jmario@redhat.com, hpa@zytor.com,
	namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip:perf/urgent] perf c2c: Increase the HITM ratio limit for displayed cachelines
Date: Thu, 3 Jan 2019 05:19:28 -0800	[thread overview]
Message-ID: <tip-c4a75bb9488a9f7b3c7e79017609529d1aa5deab@git.kernel.org> (raw)
In-Reply-To: <20181228101820.28010-2-jolsa@kernel.org>

Commit-ID:  c4a75bb9488a9f7b3c7e79017609529d1aa5deab
Gitweb:     https://git.kernel.org/tip/c4a75bb9488a9f7b3c7e79017609529d1aa5deab
Author:     Jiri Olsa <jolsa@kernel.org>
AuthorDate: Fri, 28 Dec 2018 11:18:20 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 28 Dec 2018 16:33:07 -0300

perf c2c: Increase the HITM ratio limit for displayed cachelines

The cachelines being reported are the ones with percentages all the way
down to 0.05%.  That makes for very long output files. Raising that to
0.1%.  The user can always specify --show-all if they want all the
cachelines with hits.

Suggested-by: Joe Mario <jmario@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20181228101820.28010-2-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-c2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 964f3f5ef420..d340d2e42776 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -1878,7 +1878,7 @@ static int c2c_hists__reinit(struct c2c_hists *c2c_hists,
 	return hpp_list__parse(&c2c_hists->list, output, sort);
 }
 
-#define DISPLAY_LINE_LIMIT  0.0005
+#define DISPLAY_LINE_LIMIT  0.001
 
 static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
 {

  parent reply	other threads:[~2019-01-03 13:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-28 10:18 [PATCH 1/2] perf c2c: Change the default coalesce setup Jiri Olsa
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
2018-12-28 12:39   ` Arnaldo Carvalho de Melo
2019-01-03 13:19   ` tip-bot for Jiri Olsa [this message]
2018-12-28 12:34 ` [PATCH 1/2] perf c2c: Change the default coalesce setup Arnaldo Carvalho de Melo
2019-01-03 13:18 ` [tip:perf/urgent] " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-c4a75bb9488a9f7b3c7e79017609529d1aa5deab@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jmario@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).