From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752169AbdKHK5s (ORCPT ); Wed, 8 Nov 2017 05:57:48 -0500 Received: from terminus.zytor.com ([65.50.211.136]:59599 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbdKHK5q (ORCPT ); Wed, 8 Nov 2017 05:57:46 -0500 Date: Wed, 8 Nov 2017 02:53:14 -0800 From: tip-bot for Frederic Weisbecker Message-ID: Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, paulmck@linux.vnet.ibm.com, davem@davemloft.net, hpa@zytor.com, peterz@infradead.org, torvalds@linux-foundation.org, tj@kernel.org, mingo@kernel.org, tglx@linutronix.de, frederic@kernel.org Reply-To: hpa@zytor.com, jiangshanlai@gmail.com, paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, davem@davemloft.net, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, torvalds@linux-foundation.org, peterz@infradead.org, frederic@kernel.org In-Reply-To: <1509980490-4285-5-git-send-email-frederic@kernel.org> References: <1509980490-4285-5-git-send-email-frederic@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/core] timers/nohz: Use lockdep to assert IRQs are disabled/enabled Git-Commit-ID: ebf3adbad012b89c4a51a3beae718a587d988a3a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: ebf3adbad012b89c4a51a3beae718a587d988a3a Gitweb: https://git.kernel.org/tip/ebf3adbad012b89c4a51a3beae718a587d988a3a Author: Frederic Weisbecker AuthorDate: Mon, 6 Nov 2017 16:01:20 +0100 Committer: Ingo Molnar CommitDate: Wed, 8 Nov 2017 11:13:49 +0100 timers/nohz: Use lockdep to assert IRQs are disabled/enabled Use lockdep to check that IRQs are enabled or disabled as expected. This way the sanity check only shows overhead when concurrency correctness debug code is enabled. Signed-off-by: Frederic Weisbecker Acked-by: Thomas Gleixner Cc: David S . Miller Cc: Lai Jiangshan Cc: Linus Torvalds Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Tejun Heo Link: http://lkml.kernel.org/r/1509980490-4285-5-git-send-email-frederic@kernel.org Signed-off-by: Ingo Molnar --- kernel/time/tick-sched.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index c7a899c..dd4b7b4 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -198,7 +198,7 @@ static bool check_tick_dependency(atomic_t *dep) static bool can_stop_full_tick(int cpu, struct tick_sched *ts) { - WARN_ON_ONCE(!irqs_disabled()); + lockdep_assert_irqs_disabled(); if (unlikely(!cpu_online(cpu))) return false; @@ -960,8 +960,7 @@ void tick_nohz_idle_enter(void) { struct tick_sched *ts; - WARN_ON_ONCE(irqs_disabled()); - + lockdep_assert_irqs_enabled(); /* * Update the idle state in the scheduler domain hierarchy * when tick_nohz_stop_sched_tick() is called from the idle loop.