From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
Subject: Re: [PATCH] drivers/ata: remove flood "Enabling discard_zeroes_data"
Date: Fri, 07 Jun 2019 13:26:54 -0400 [thread overview]
Message-ID: <yq1sgsli9wh.fsf@oracle.com> (raw)
In-Reply-To: <155989286981.1471.16344793966539115439.stgit@buzz> (Konstantin Khlebnikov's message of "Fri, 07 Jun 2019 10:34:29 +0300")
Konstantin,
> Printing this at each SCSI READ_CAPACITY command is too verbose.
>
> Flag "discard_zeroes_data" is deprecated since commit 48920ff2a5a9
> ("block: remove the discard_zeroes_data flag").
> - dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM) {
> - ata_dev_info(dev, "Enabling discard_zeroes_data\n");
> + dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM)
> rbuf[14] |= 0x40; /* LBPRZ */
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-06-07 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 7:34 [PATCH] drivers/ata: remove flood "Enabling discard_zeroes_data" Konstantin Khlebnikov
2019-06-07 17:26 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sgsli9wh.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).