From: Jan Kara <jack@suse.cz>
To: Tom Rix <trix@redhat.com>
Cc: nathan@kernel.org, ndesaulniers@google.com, willy@infradead.org,
akpm@linux-foundation.org, jack@suse.cz, jlayton@kernel.org,
song@kernel.org, yi.zhang@huawei.com, bvanassche@acm.org,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] reiserfs: remove unused sched_count variable
Date: Mon, 27 Mar 2023 10:57:49 +0200 [thread overview]
Message-ID: <20230327085749.feyfegzdjxqhymdu@quack3> (raw)
In-Reply-To: <20230326204459.1358553-1-trix@redhat.com>
On Sun 26-03-23 16:44:59, Tom Rix wrote:
> clang with W=1 reports
> fs/reiserfs/journal.c:3034:6: error: variable
> 'sched_count' set but not used [-Werror,-Wunused-but-set-variable]
> int sched_count = 0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Thanks. I've added the fix to my tree.
Honza
> ---
> fs/reiserfs/journal.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 9ce4ec296b74..4d11d60f493c 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -3031,7 +3031,6 @@ static int do_journal_begin_r(struct reiserfs_transaction_handle *th,
> unsigned int old_trans_id;
> struct reiserfs_journal *journal = SB_JOURNAL(sb);
> struct reiserfs_transaction_handle myth;
> - int sched_count = 0;
> int retval;
> int depth;
>
> @@ -3088,7 +3087,6 @@ static int do_journal_begin_r(struct reiserfs_transaction_handle *th,
> ((journal->j_len + nblocks + 2) * 100) <
> (journal->j_len_alloc * 75)) {
> if (atomic_read(&journal->j_wcount) > 10) {
> - sched_count++;
> queue_log_writer(sb);
> goto relock;
> }
> --
> 2.27.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-03-27 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 20:44 [PATCH] reiserfs: remove unused sched_count variable Tom Rix
2023-03-27 8:57 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327085749.feyfegzdjxqhymdu@quack3 \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=song@kernel.org \
--cc=trix@redhat.com \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).