Re: [PATCH v1 1/2] LoongArch: dts: Add new supported device nodes to Loongson-2K0500

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

On Wed, May 08, 2024 at 04:29:10PM +0800, Binbin Zhou wrote:
> By now, more Loongson-2K0500 related drivers are supported, such as
> clock controller, thermal controller, and dma controller.
> Now we add these device nodes to the Loongson-2K0500 dts file.
> 
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
>  .../boot/dts/loongson-2k0500-ref.dts          |  4 +
>  arch/loongarch/boot/dts/loongson-2k0500.dtsi  | 81 ++++++++++++++++++-
>  2 files changed, 82 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> index 8aefb0c12672..62dad6297e82 100644
> --- a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> +++ b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> @@ -41,6 +41,10 @@ linux,cma {
>  	};
>  };
>  
> +&clk {
> +	status = "okay";
> +};

For most devices, doing the "disable in dtsi, enable in dts" approach is
the right thing to do, but for things like clock-controllers or
architectural interrupt controllers that no-one is going to disable
since they'll not have a usable system otherwise, it's not needed.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]