From: Wei Gao via ltp <ltp@lists.linux.it>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] recvmsg01: Refactor using new LTP API
Date: Sun, 30 Apr 2023 03:15:53 -0400 [thread overview]
Message-ID: <ZE4VqQYBEtqywtgp@localhost> (raw)
In-Reply-To: <20230428124648.GA3209331@pevik>
On Fri, Apr 28, 2023 at 02:46:48PM +0200, Petr Vorel wrote:
> Hi Wei,
>
> First, for some reason, with higher number of run "bad file descriptor" will
> fail, returning 0 instead of -1.
> It starts to fail from 200th:
> $ ./recvmsg01 -i 200
>
> ...
> recvmsg01.c:283: TPASS: invalid iovec count successful
> recvmsg01.c:283: TPASS: rights reception successful
> recvmsg01.c:283: TPASS: invalid MSG_OOB flag set successful
> recvmsg01.c:283: TPASS: invalid MSG_ERRQUEUE flag set successful
> recvmsg01.c:283: TPASS: large cmesg length successful
> recvmsg01.c:276: TFAIL: bad file descriptor ; returned 0 (expected -1), errno 0 (expected 9): SUCCESS (0)
>
> Summary:
> passed 1999
> failed 1
> broken 0
> skipped 0
> warnings 0
>
> I also did some review, but I didn't have time to check properly whether subject
> of testing is valid (quite complex test).
>
Thanks for your careful test.
I spent lot of time to investigat why this happen, finally i found it caused by wrong
cleanup of the sock fd.
I also put this fix in v3 patch.
> > +static void setup_large_msg_control(int n)
> > {
> > - setup2();
> > - controllen = sizeof(struct cmsghdr) - 1;
> > + setup_valid_msg_control(n);
> > + controllen = 128 * BUF_SIZE;
> Any idea why 128? What is this number for?
> > }
I think this is random select number when this case first introduced.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-04-30 7:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 13:38 [LTP] [PATCH v1] recvmsg01: Refactor using new LTP API Wei Gao via ltp
2023-03-30 5:17 ` Petr Vorel
2023-03-30 5:58 ` Petr Vorel
2023-04-24 10:30 ` [LTP] [PATCH v2] " Wei Gao via ltp
2023-04-28 12:46 ` Petr Vorel
2023-04-30 7:15 ` Wei Gao via ltp [this message]
2023-04-30 6:04 ` [LTP] [PATCH v3] " Wei Gao via ltp
2023-05-02 10:31 ` Petr Vorel
2023-05-02 10:32 ` Petr Vorel
2023-05-02 11:53 ` Wei Gao via ltp
2023-05-02 14:12 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZE4VqQYBEtqywtgp@localhost \
--to=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).