lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: mingli.yu@windriver.com, lttng-dev@lists.lttng.org
Subject: Re: [babeltrace][PATCH] fs.c: initialize the other_entry variable
Date: Wed, 11 Mar 2020 09:52:27 -0400	[thread overview]
Message-ID: <a2a63a78-f39b-b64a-f09a-08e096dc6563@simark.ca> (raw)
In-Reply-To: <1583933970-68840-1-git-send-email-mingli.yu@windriver.com>

On 2020-03-11 9:39 a.m., mingli.yu@windriver.com wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
> 
> Initialize the pointer other_entry to fix the below error:
> | ../../../../../git/src/plugins/ctf/fs-src/fs.c: In function 'ds_index_insert_ds_index_entry_sorted':
> | ../../../../../git/src/plugins/ctf/fs-src/fs.c:702:5: error: 'other_entry' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> |  702 |    !ds_index_entries_equal(entry, other_entry)) {
> 
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>

Hi Mingli,

Thanks for the patch.  Could you please mention the compiler you are using
(which architecture and which version), as well as the full command line
used to compile that file (shown with "make V=1"?

Thank you,

Simon

  reply	other threads:[~2020-03-11 14:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 13:39 [babeltrace][PATCH] fs.c: initialize the other_entry variable mingli.yu
2020-03-11 13:52 ` Simon Marchi [this message]
2020-03-12  3:37   ` Yu, Mingli via lttng-dev
2020-03-11 13:58 ` Mathieu Desnoyers
2020-03-12  3:42   ` [babeltrace][PATCH v2] " mingli.yu--- via lttng-dev
  -- strict thread matches above, loose matches on Subject: below --
2020-03-11 13:25 [babeltrace][PATCH] " mingli.yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2a63a78-f39b-b64a-f09a-08e096dc6563@simark.ca \
    --to=simark@simark.ca \
    --cc=lttng-dev@lists.lttng.org \
    --cc=mingli.yu@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).