lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
From: Simon Marchi via lttng-dev <lttng-dev@lists.lttng.org>
To: Rocky Dunlap <dunlap@ucar.edu>, lttng-dev@lists.lttng.org
Subject: Re: Babeltrace2 - compilation error with intel18
Date: Fri, 20 Mar 2020 17:47:56 -0400	[thread overview]
Message-ID: <b2e4fcfb-eb65-5205-1de3-0e0dbfb7fb48@simark.ca> (raw)
In-Reply-To: <CADtyBo7jFiv-E-DCp4kYfY7WRSLsN3Oos6iRr35Sy9o=iNZKOg@mail.gmail.com>

On 2020-03-20 5:10 p.m., Rocky Dunlap via lttng-dev wrote:
> I am trying to compile BT2 with Python bindings using Intel18.  I receive the following error during the build:
Hi Rocky,

I don't think we claim to support the Intel compiler, so you might be a bit
on your own here.  Although if you want to send patches to fix the build using
that compiler, I don't have anything against that.

> 
> In file included from py-common.c(31):
> /apps/intel/intelpython3/include/python3.6m/Python.h(149): error #193: zero used for undefined preprocessing identifier "_MSC_VER"
>   #if _MSC_VER
>       ^
> 
> In file included from py-common.c(31):
> /apps/intel/intelpython3/include/python3.6m/Python.h(151): error #193: zero used for undefined preprocessing identifier "__clang__"
>   #elif __clang__ || __GNUC__
>         ^

It took me a bit of time to understand that this is Intel's Python 3
distribution, not CPython.

I think it's technically valid to use an undefined macro in a preprocessor
condition like that, in which case it gets replaced with 0 (as the error
message mentions).  The compiler is trying to be helpful and warns you, because
relying on that behavior is a bit fragile, and often a sign of a mistake
somewhere.  But since this happens in a library you are using, I think your best
bet is just to disable this warning.

> py-common.c(187): error #3179: deprecated conversion of string literal to char* (should be const char*)
>   format_exc_func_name = py_exc_tb ? "format_exception" :

I really don't understand this one, as format_exc_func_name is a const char *
in our code.

Simon

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

  reply	other threads:[~2020-03-20 21:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 21:10 Babeltrace2 - compilation error with intel18 Rocky Dunlap via lttng-dev
2020-03-20 21:47 ` Simon Marchi via lttng-dev [this message]
2020-03-20 21:55   ` Rocky Dunlap via lttng-dev
2020-03-20 22:20     ` Simon Marchi via lttng-dev
2020-03-20 22:32       ` Rocky Dunlap via lttng-dev
2020-03-21  3:12         ` Simon Marchi via lttng-dev
2020-03-23 15:44           ` Simon Marchi via lttng-dev
2020-03-23 16:05             ` Rocky Dunlap via lttng-dev
2020-03-23 16:14               ` Simon Marchi via lttng-dev
2020-03-23 16:56                 ` Rocky Dunlap via lttng-dev
2020-03-23 17:24                   ` Simon Marchi via lttng-dev
2020-03-23 17:37                     ` Rocky Dunlap via lttng-dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2e4fcfb-eb65-5205-1de3-0e0dbfb7fb48@simark.ca \
    --to=lttng-dev@lists.lttng.org \
    --cc=dunlap@ucar.edu \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).