From: Manivannan Sadhasivam <mani@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
hemantk@codeaurora.org, bbhatt@codeaurora.org,
loic.poulain@linaro.org, wangqing@vivo.com, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 2/3] bus: mhi: Add inbound buffers allocation flag
Date: Sat, 16 Oct 2021 22:01:28 +0530 [thread overview]
Message-ID: <20211016163128.GC4048@thinkpad> (raw)
In-Reply-To: <YWqByX6rdfuA1h1F@kroah.com>
On Sat, Oct 16, 2021 at 09:39:53AM +0200, Greg KH wrote:
> On Sat, Oct 16, 2021 at 12:27:33PM +0530, Manivannan Sadhasivam wrote:
> > From: Loic Poulain <loic.poulain@linaro.org>
> >
> > Currently, the MHI controller driver defines which channels should
> > have their inbound buffers allocated and queued. But ideally, this is
> > something that should be decided by the MHI device driver instead,
> > which actually deals with that buffers.
> >
> > Add a flag parameter to mhi_prepare_for_transfer allowing to specify
> > if buffers have to be allocated and queued by the MHI stack.
>
> This is a horrible api. Now one has to go and look up why "0" was added
> to a function as a parameter.
>
> If you don't want to allocate the buffer, then make a function of that
> name and call that. As you only have one "flag", don't try to make
> something generic here that is obviously not generic at all.
>
This is the only API that can be used by the client drivers to pass the
configurations to the MHI stack. So we wanted to have a flags parameter that
could be extended in the future also.
Regarding "0", the default behaviour is to not pre allocate the buffer at all.
So it made less sense to add a separate flag or an API for that.
Thanks,
Mani
> You all can do better than this.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2021-10-16 16:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 6:57 [PATCH 0/3] MHI patches for v5.16 Manivannan Sadhasivam
2021-10-16 6:57 ` [PATCH 1/3] MAINTAINERS: Update the entry for MHI bus Manivannan Sadhasivam
2021-10-16 7:34 ` Greg KH
2021-10-19 4:19 ` Hemant Kumar
2021-10-19 12:24 ` Greg KH
2021-10-19 13:26 ` Manivannan Sadhasivam
2021-10-16 6:57 ` [PATCH 2/3] bus: mhi: Add inbound buffers allocation flag Manivannan Sadhasivam
2021-10-16 7:39 ` Greg KH
2021-10-16 16:31 ` Manivannan Sadhasivam [this message]
2021-10-17 7:07 ` Greg KH
2021-10-16 6:57 ` [PATCH 3/3] bus: mhi: replace snprintf in show functions with sysfs_emit Manivannan Sadhasivam
2021-10-16 7:37 ` Greg KH
2021-10-16 10:24 ` Joe Perches
2021-10-16 15:07 ` Greg KH
2021-10-16 15:13 ` Joe Perches
2021-10-16 16:15 ` Manivannan Sadhasivam
2021-10-19 4:30 ` Hemant Kumar
2021-10-16 16:19 ` Manivannan Sadhasivam
2021-10-16 7:00 ` [PATCH 0/3] MHI patches for v5.16 Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016163128.GC4048@thinkpad \
--to=mani@kernel.org \
--cc=bbhatt@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).