From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A93AC433DF for ; Wed, 12 Aug 2020 01:31:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61B8B207DA for ; Wed, 12 Aug 2020 01:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597195893; bh=zRGeNM6mpYmWTG1hl4rMZdDYVTJmyd34zKe0DAJKaMs=; h=Date:From:To:Subject:In-Reply-To:Reply-To:List-ID:From; b=EuQBMvefhmwUR+rTt42xr8z13s1tGeh4TdMkN13KHU49J2gznP/0i2rv3bRW4psVG w1t5sLy4S0cl4jbnlhSZEz+D9fkKz5/lV6sh4si5432kLiNVPVJCdNTMad08qD5iVN Wz/FbP1cJcjCvgNOD3cPSAS+GswVYWV7Iu/11qws= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726488AbgHLBbd (ORCPT ); Tue, 11 Aug 2020 21:31:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:58942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726235AbgHLBbd (ORCPT ); Tue, 11 Aug 2020 21:31:33 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D51E206B2; Wed, 12 Aug 2020 01:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597195892; bh=zRGeNM6mpYmWTG1hl4rMZdDYVTJmyd34zKe0DAJKaMs=; h=Date:From:To:Subject:In-Reply-To:From; b=im5NYhn8mml1t0UHky5AzX/Jcxk4JsBxFi92zHdDckqmF8oumNQYbZZ1DqC1VZhf9 asqK9nIt2Cg/aMdaXvRnKGfeqOH6c/HlpDOx/Bkbs2c8sk8/IhdBnXodidAegtU1J9 2K71y1Q8I2LV+i2Vq2W9ve8PunaBLCij6SdPLT34= Date: Tue, 11 Aug 2020 18:31:32 -0700 From: Andrew Morton To: akpm@linux-foundation.org, cai@lca.pw, laoar.shao@gmail.com, linux-mm@kvack.org, mhocko@suse.com, mm-commits@vger.kernel.org, penguin-kernel@i-love.sakura.ne.jp, rientjes@google.com, torvalds@linux-foundation.org Subject: [patch 024/165] mm, oom: show process exiting information in __oom_kill_process() Message-ID: <20200812013132.y2HAP8zOp%akpm@linux-foundation.org> In-Reply-To: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> User-Agent: s-nail v14.8.16 Sender: mm-commits-owner@vger.kernel.org Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Yafang Shao Subject: mm, oom: show process exiting information in __oom_kill_process() When the OOM killer finds a victim and tryies to kill it, if the victim is already exiting, the task mm will be NULL and no process will be killed. But the dump_header() has been already executed, so it will be strange to dump so much information without killing a process. We'd better show some helpful information to indicate why this happens. Link: http://lkml.kernel.org/r/20200721010127.17238-1-laoar.shao@gmail.com Signed-off-by: Yafang Shao Suggested-by: David Rientjes Acked-by: Michal Hocko Cc: Tetsuo Handa Cc: Qian Cai Signed-off-by: Andrew Morton --- mm/oom_kill.c | 2 ++ 1 file changed, 2 insertions(+) --- a/mm/oom_kill.c~mm-oom-show-process-exiting-information-in-__oom_kill_process +++ a/mm/oom_kill.c @@ -861,6 +861,8 @@ static void __oom_kill_process(struct ta p = find_lock_task_mm(victim); if (!p) { + pr_info("%s: OOM victim %d (%s) is already exiting. Skip killing the task\n", + message, task_pid_nr(victim), victim->comm); put_task_struct(victim); return; } else if (victim != p) { _