From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A525BC11F65 for ; Tue, 29 Jun 2021 02:37:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 943C061D09 for ; Tue, 29 Jun 2021 02:37:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231802AbhF2Cjo (ORCPT ); Mon, 28 Jun 2021 22:39:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:60396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231724AbhF2Cjn (ORCPT ); Mon, 28 Jun 2021 22:39:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8546561A2B; Tue, 29 Jun 2021 02:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1624934237; bh=/POV9UGgpCHcoyUw9DZKte6UudXS13gszgGH8144giU=; h=Date:From:To:Subject:In-Reply-To:From; b=CmS0oOhG48lqbOPvD/NEuM13vA1tX3zwNxnskNUUnIqa77f6AT3GpJd2f9lzrqHUp 8TTA196QrsXcNajdICYXaaKxe1JUaOboR4po4pQVHqb7OVgVhBkuzr8PIcMzgJ4k7h BjDpYnj3lJi1CdcH2ZRmwoeEgeOLLdlz02DL0Z3U= Date: Mon, 28 Jun 2021 19:37:16 -0700 From: Andrew Morton To: akpm@linux-foundation.org, dan.j.williams@intel.com, hannes@cmpxchg.org, hch@lst.de, hughd@google.com, iamjoonsoo.kim@lge.com, idryomov@gmail.com, linmiaohe@huawei.com, linux-mm@kvack.org, mgorman@techsingularity.net, mhocko@kernel.org, minchan@kernel.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, vbabka@suse.cz, willy@infradead.org, ying.huang@intel.com Subject: [patch 076/192] swap: check mapping_empty() for swap cache before being freed Message-ID: <20210629023716.zBdJg2iAG%akpm@linux-foundation.org> In-Reply-To: <20210628193256.008961950a714730751c1423@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Huang Ying Subject: swap: check mapping_empty() for swap cache before being freed To check whether all pages and shadow entries in swap cache has been removed before swap cache is freed. Link: https://lkml.kernel.org/r/20210608005121.511140-1-ying.huang@intel.com Signed-off-by: "Huang, Ying" Cc: Miaohe Lin Cc: Matthew Wilcox Cc: Minchan Kim Cc: Joonsoo Kim Cc: Johannes Weiner Cc: Vlastimil Babka Cc: Hugh Dickins Cc: Mel Gorman Cc: Michal Hocko Cc: Dan Williams Cc: Christoph Hellwig Cc: Ilya Dryomov Signed-off-by: Andrew Morton --- mm/swap_state.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/mm/swap_state.c~swap-check-mapping_empty-for-swap-cache-before-being-freed +++ a/mm/swap_state.c @@ -693,7 +693,12 @@ int init_swap_address_space(unsigned int void exit_swap_address_space(unsigned int type) { - kvfree(swapper_spaces[type]); + int i; + struct address_space *spaces = swapper_spaces[type]; + + for (i = 0; i < nr_swapper_spaces[type]; i++) + VM_WARN_ON_ONCE(!mapping_empty(&spaces[i])); + kvfree(spaces); nr_swapper_spaces[type] = 0; swapper_spaces[type] = NULL; } _