From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19FFCC433FE for ; Tue, 22 Mar 2022 21:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236719AbiCVVtQ (ORCPT ); Tue, 22 Mar 2022 17:49:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236844AbiCVVsx (ORCPT ); Tue, 22 Mar 2022 17:48:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B455F606C0 for ; Tue, 22 Mar 2022 14:47:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 515416104C for ; Tue, 22 Mar 2022 21:47:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A67DCC340F2; Tue, 22 Mar 2022 21:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1647985639; bh=CM1n9mzzhlL7za/LeGoqlxU72kT0yRPY/3c8VjkAdpw=; h=Date:To:From:In-Reply-To:Subject:From; b=NcQ7n2NFi96gYLMps5hb3/IiVGnhOXfQgX77FnwXfR4FrBaS0KWepr+YRsiIW14fo kZAd9Qzqc/CzXiQtRte5j9yuXADOLjQQ4FLncXLqTbYpWSpG0/tGTYWAPLmz28hsMD RdUlZIBUc4z8SiV6CIWZuLr/pqjvTLLEmHzE+Tjk= Date: Tue, 22 Mar 2022 14:47:19 -0700 To: osalvador@suse.de, david@redhat.com, linmiaohe@huawei.com, akpm@linux-foundation.org, patches@lists.linux.dev, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org From: Andrew Morton In-Reply-To: <20220322143803.04a5e59a07e48284f196a2f9@linux-foundation.org> Subject: [patch 173/227] mm/memory_hotplug: avoid calling zone_intersects() for ZONE_NORMAL Message-Id: <20220322214719.A67DCC340F2@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org From: Miaohe Lin Subject: mm/memory_hotplug: avoid calling zone_intersects() for ZONE_NORMAL If zid reaches ZONE_NORMAL, the caller will always get the NORMAL zone no matter what zone_intersects() returns. So we can save some possible cpu cycles by avoid calling zone_intersects() for ZONE_NORMAL. Link: https://lkml.kernel.org/r/20220207133643.23427-3-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Reviewed-by: David Hildenbrand Reviewed-by: Oscar Salvador Signed-off-by: Andrew Morton --- mm/memory_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/memory_hotplug.c~mm-memory_hotplug-avoid-calling-zone_intersects-for-zone_normal +++ a/mm/memory_hotplug.c @@ -823,7 +823,7 @@ static struct zone *default_kernel_zone_ struct pglist_data *pgdat = NODE_DATA(nid); int zid; - for (zid = 0; zid <= ZONE_NORMAL; zid++) { + for (zid = 0; zid < ZONE_NORMAL; zid++) { struct zone *zone = &pgdat->node_zones[zid]; if (zone_intersects(zone, start_pfn, nr_pages)) _