mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Zaslonko Mikhail <zaslonko@linux.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	borntraeger@de.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com,
	iii@linux.ibm.com, linux-mm@kvack.org, lkp@intel.com,
	mm-commits@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [patch 01/12] zlib: export S390 symbols for zlib modules
Date: Fri, 18 Dec 2020 14:18:05 -0800	[thread overview]
Message-ID: <dcbebf98-1313-f95d-b2dc-6c2a134439d2@infradead.org> (raw)
In-Reply-To: <1d4cccc2-5e71-d09b-9b1b-03f30427af56@linux.ibm.com>

On 12/8/20 12:19 AM, Zaslonko Mikhail wrote:
> 
> 
> On 08.12.2020 01:45, Randy Dunlap wrote:
>> On 12/7/20 1:03 AM, Zaslonko Mikhail wrote:
>>> Hello,
>>>
>>> should we probably put these to lib/zlib_dfltcc/dfltcc_syms.c along with the other EXPORT_SYMBOL statements?
>>
>> Hi,
>> I didn't know about that file. :)
>>
>> That change makes sense. At least that's how some modules used
>> to do it. Not so much nowadays, but this one might as well
>> consistent within itself.
>>
>> Do you want to fix it or should I?
> 
> Please, go ahead.
> 
> Thanks.

Hi,

How do you feel about eliminating the dfltcc_syms.c file and
putting the EXPORT_SYMBOL()s in the source file(s) where they
occur?  as expressed in coding-style.rst:

In source files, separate functions with one blank line.  If the function is
exported, the **EXPORT** macro for it should follow immediately after the
closing function brace line.

(also move the MODULE_LICENSE() to a different source file.)

>>
>> Thanks.
>>
>>> Reviewed-by: Mikhail Zaslonko <zaslonko@linux.ibm.com>
>>>
>>> On 06.12.2020 07:14, Andrew Morton wrote:
>>>> From: Randy Dunlap <rdunlap@infradead.org>
>>>> Subject: zlib: export S390 symbols for zlib modules
>>>>
>>>> Fix build errors when ZLIB_INFLATE=m and ZLIB_DEFLATE=m and ZLIB_DFLTCC=y
>>>> by exporting the 2 needed symbols in dfltcc_inflate.c.


thanks.
-- 
~Randy


  reply	other threads:[~2020-12-18 22:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06  6:14 incoming Andrew Morton
2020-12-06  6:14 ` [patch 01/12] zlib: export S390 symbols for zlib modules Andrew Morton
2020-12-07  9:03   ` Zaslonko Mikhail
2020-12-08  0:45     ` Randy Dunlap
2020-12-08  8:19       ` Zaslonko Mikhail
2020-12-18 22:18         ` Randy Dunlap [this message]
2020-12-06  6:14 ` [patch 02/12] coredump: fix core_pattern parse error Andrew Morton
2020-12-06  6:14 ` [patch 03/12] mm: memcg/slab: fix obj_cgroup_charge() return value handling Andrew Morton
2020-12-06  6:14 ` [patch 04/12] mm: list_lru: set shrinker map bit when child nr_items is not zero Andrew Morton
2020-12-06  6:14 ` [patch 05/12] mm/zsmalloc.c: drop ZSMALLOC_PGTABLE_MAPPING Andrew Morton
2020-12-06  6:14 ` [patch 06/12] mm/swapfile: do not sleep with a spin lock held Andrew Morton
2020-12-06  6:14 ` [patch 07/12] mailmap: add two more addresses of Uwe Kleine-König Andrew Morton
2020-12-06  6:15 ` [patch 08/12] tools/testing/selftests/vm: fix build error Andrew Morton
2020-12-06  6:15 ` [patch 09/12] userfaultfd: selftests: fix SIGSEGV if huge mmap fails Andrew Morton
2020-12-06  6:15 ` [patch 10/12] mm/filemap: add static for function __add_to_page_cache_locked Andrew Morton
2020-12-06  6:15 ` [patch 11/12] hugetlb_cgroup: fix offline of hugetlb cgroup with reservations Andrew Morton
2020-12-06  6:15 ` [patch 12/12] mm/mmap.c: fix mmap return value when vma is merged after call_mmap() Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcbebf98-1313-f95d-b2dc-6c2a134439d2@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=borntraeger@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=zaslonko@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).