From: Florian Westphal <fw@strlen.de>
To: Maxim Mikityanskiy <maximmi@nvidia.com>
Cc: "Mat Martineau" <mathew.j.martineau@linux.intel.com>,
"Matthieu Baerts" <matthieu.baerts@tessares.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
"Jozsef Kadlecsik" <kadlec@netfilter.org>,
"Florian Westphal" <fw@strlen.de>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Patrick McHardy" <kaber@trash.net>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Christoph Paasch" <cpaasch@apple.com>,
"Peter Krystad" <peter.krystad@linux.intel.com>,
"Young Xiao" <92siuyang@gmail.com>,
netdev@vger.kernel.org, mptcp@lists.linux.dev
Subject: Re: [PATCH net v2 1/3] netfilter: synproxy: Fix out of bounds when parsing TCP options
Date: Thu, 10 Jun 2021 18:43:52 +0200 [thread overview]
Message-ID: <20210610164352.GQ20020@breakpoint.cc> (raw)
In-Reply-To: <20210610164031.3412479-2-maximmi@nvidia.com>
Maxim Mikityanskiy <maximmi@nvidia.com> wrote:
> The TCP option parser in synproxy (synproxy_parse_options) could read
> one byte out of bounds. When the length is 1, the execution flow gets
> into the loop, reads one byte of the opcode, and if the opcode is
> neither TCPOPT_EOL nor TCPOPT_NOP, it reads one more byte, which exceeds
> the length of 1.
>
> This fix is inspired by commit 9609dad263f8 ("ipv4: tcp_input: fix stack
> out of bounds when parsing TCP options.").
Reviewed-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2021-06-10 17:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 16:40 [PATCH net v2 0/3] Fix out of bounds when parsing TCP options Maxim Mikityanskiy
2021-06-10 16:40 ` [PATCH net v2 1/3] netfilter: synproxy: " Maxim Mikityanskiy
2021-06-10 16:43 ` Florian Westphal [this message]
2021-06-10 16:40 ` [PATCH net v2 2/3] mptcp: " Maxim Mikityanskiy
2021-06-10 21:03 ` Mat Martineau
2021-06-10 21:09 ` Mat Martineau
2021-06-11 14:30 ` Matthieu Baerts
2021-06-10 16:40 ` [PATCH net v2 3/3] sch_cake: Fix out of bounds when parsing TCP options and header Maxim Mikityanskiy
2021-06-10 21:50 ` [PATCH net v2 0/3] Fix out of bounds when parsing TCP options patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610164352.GQ20020@breakpoint.cc \
--to=fw@strlen.de \
--cc=92siuyang@gmail.com \
--cc=brouer@redhat.com \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kaber@trash.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=maximmi@nvidia.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=peter.krystad@linux.intel.com \
--cc=toke@toke.dk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).