From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Nico Pache <npache@redhat.com>, linux-kernel@vger.kernel.org
Cc: brendanhiggins@google.com, gregkh@linuxfoundation.org,
linux-ext4@vger.kernel.org, netdev@vger.kernel.org,
rafael@kernel.org, linux-m68k@lists.linux-m68k.org,
geert@linux-m68k.org, tytso@mit.edu,
mathew.j.martineau@linux.intel.com, davem@davemloft.net,
broonie@kernel.org, davidgow@google.com,
skhan@linuxfoundation.org, mptcp@lists.linux.dev
Subject: Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard
Date: Wed, 14 Apr 2021 11:25:03 +0200 [thread overview]
Message-ID: <e26fbcc8-ba3e-573a-523d-9c5d5f84bc46@tessares.net> (raw)
In-Reply-To: <0fa191715b236766ad13c5f786d8daf92a9a0cf2.1618388989.git.npache@redhat.com>
Hi Nico,
On 14/04/2021 10:58, Nico Pache wrote:
> Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the
> KUNIT *_KUNIT_TEST config name format.
For MPTCP, we have multiple KUnit tests: crypto and token. That's why we
wrote TESTS with a S.
I'm fine without S if we need to stick with KUnit' standard. But maybe
the standard wants us to split the two tests and create
MPTCP_TOKEN_KUNIT_TEST and MPTCP_TOKEN_KUNIT_TEST config?
In this case, we could eventually keep MPTCP_KUNIT_TESTS which will in
charge of selecting the two new ones.
Up to the KUnit maintainers to decide ;-)
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2021-04-14 9:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 8:58 [PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard Nico Pache
2021-04-14 8:58 ` [PATCH v2 1/6] kunit: ASoC: topology: adhear to KUNIT formatting standard Nico Pache
2021-04-14 14:20 ` Mark Brown
2021-04-14 8:58 ` [PATCH v2 2/6] kunit: software node: " Nico Pache
2021-04-14 8:58 ` [PATCH v2 3/6] kunit: ext4: " Nico Pache
2021-04-18 19:41 ` Theodore Ts'o
2021-04-14 8:58 ` [PATCH v2 4/6] kunit: lib: " Nico Pache
2021-04-14 8:58 ` [PATCH v2 5/6] kunit: mptcp: " Nico Pache
2021-04-14 9:25 ` Matthieu Baerts [this message]
2021-04-15 6:01 ` David Gow
2021-04-15 7:10 ` Matthieu Baerts
2021-04-17 4:24 ` David Gow
2021-04-17 8:02 ` Matthieu Baerts
2021-04-19 7:40 ` Geert Uytterhoeven
2021-04-14 8:58 ` [PATCH v2 6/6] m68k: update configs to match the proper KUNIT syntax Nico Pache
2021-04-14 16:06 ` (subset) [PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard Mark Brown
2021-04-18 19:39 ` Theodore Ts'o
2021-04-22 20:39 ` Nico Pache
2021-04-23 6:26 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e26fbcc8-ba3e-573a-523d-9c5d5f84bc46@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=npache@redhat.com \
--cc=rafael@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).