From: David Ahern <dsahern@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ido Schimmel <idosch@idosch.org>,
Thomas Haller <thaller@redhat.com>
Subject: Re: [PATCH net-next] ipv6: do not merge differe type and protocol routes
Date: Wed, 30 Aug 2023 08:49:18 -0600 [thread overview]
Message-ID: <06c4cd5f-7241-3a72-0cab-5319b2c8a793@kernel.org> (raw)
In-Reply-To: <20230830061550.2319741-1-liuhangbin@gmail.com>
On 8/30/23 12:15 AM, Hangbin Liu wrote:
> Different with IPv4, IPv6 will auto merge the same metric routes into
> multipath routes. But the different type and protocol routes are also
> merged, which will lost user's configure info. e.g.
>
> + ip route add local 2001:db8:103::/64 via 2001:db8:101::10 dev dummy1 table 100
> + ip route append unicast 2001:db8:103::/64 via 2001:db8:101::10 dev dummy2 table 100
> + ip -6 route show table 100
> local 2001:db8:103::/64 metric 1024 pref medium
> nexthop via 2001:db8:101::10 dev dummy1 weight 1
> nexthop via 2001:db8:101::10 dev dummy2 weight 1
>
> + ip route add 2001:db8:104::/64 via 2001:db8:101::10 dev dummy1 proto kernel table 200
> + ip route append 2001:db8:104::/64 via 2001:db8:101::10 dev dummy2 proto bgp table 200
> + ip -6 route show table 200
> 2001:db8:104::/64 proto kernel metric 1024 pref medium
> nexthop via 2001:db8:101::10 dev dummy1 weight 1
> nexthop via 2001:db8:101::10 dev dummy2 weight 1
>
> So let's skip counting the different type and protocol routes as siblings.
> After update, the different type/protocol routes will not be merged.
>
> + ip -6 route show table 100
> local 2001:db8:103::/64 via 2001:db8:101::10 dev dummy1 metric 1024 pref medium
> 2001:db8:103::/64 via 2001:db8:101::10 dev dummy2 metric 1024 pref medium
>
> + ip -6 route show table 200
> 2001:db8:104::/64 via 2001:db8:101::10 dev dummy1 proto kernel metric 1024 pref medium
> 2001:db8:104::/64 via 2001:db8:101::10 dev dummy2 proto bgp metric 1024 pref medium
>
> Reported-by: Thomas Haller <thaller@redhat.com>
> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2161994
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> All fib test passed:
> Tests passed: 203
> Tests failed: 0
Please add the above tests for this case to the fib tests script.
> ---
> net/ipv6/ip6_fib.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
> index 28b01a068412..f60f5d14f034 100644
> --- a/net/ipv6/ip6_fib.c
> +++ b/net/ipv6/ip6_fib.c
> @@ -1133,6 +1133,11 @@ static int fib6_add_rt2node(struct fib6_node *fn, struct fib6_info *rt,
> rt->fib6_pmtu);
> return -EEXIST;
> }
> +
> + if (iter->fib6_type != rt->fib6_type ||
> + iter->fib6_protocol != rt->fib6_protocol)
> + goto next_iter;
> +
> /* If we have the same destination and the same metric,
> * but not the same gateway, then the route we try to
> * add is sibling to this route, increment our counter
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-08-30 14:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 6:15 [PATCH net-next] ipv6: do not merge differe type and protocol routes Hangbin Liu
2023-08-30 14:49 ` David Ahern [this message]
2023-08-30 23:51 ` Hangbin Liu
2023-08-30 15:29 ` Nicolas Dichtel
2023-08-30 18:57 ` David Ahern
2023-08-31 8:17 ` Nicolas Dichtel
2023-08-31 10:14 ` Hangbin Liu
2023-08-31 11:58 ` Nicolas Dichtel
2023-08-31 18:27 ` David Ahern
2023-09-01 9:36 ` Nicolas Dichtel
2023-09-15 2:23 ` Hangbin Liu
2023-09-15 3:08 ` David Ahern
2023-09-15 10:02 ` Hangbin Liu
2023-09-01 3:58 ` Hangbin Liu
2023-09-01 9:50 ` Nicolas Dichtel
2023-09-15 3:49 ` Hangbin Liu
2023-09-15 15:58 ` Nicolas Dichtel
2023-08-30 6:16 Hangbin Liu
2023-08-30 9:37 ` Hangbin Liu
2023-08-30 9:48 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06c4cd5f-7241-3a72-0cab-5319b2c8a793@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).