netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: "grundler@chromium.org" <grundler@chromium.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	nic_swsd <nic_swsd@realtek.com>
Subject: RE: [PATCH net-next] r8152: Add identifier names for function pointers
Date: Thu, 3 Oct 2019 02:03:51 +0000	[thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2F18E612E@RTITMBSVM03.realtek.com.tw> (raw)
In-Reply-To: <20191002210933.122122-1-pmalani@chromium.org>

Prashant Malani [mailto:pmalani@chromium.org]
> Sent: Thursday, October 03, 2019 5:10 AM
> To: Hayes Wang
> Cc: grundler@chromium.org; netdev@vger.kernel.org; nic_swsd; Prashant
> Malani
> Subject: [PATCH net-next] r8152: Add identifier names for function pointers
> 
> Checkpatch throws warnings for function pointer declarations which lack
> identifier names.
> 
> An example of such a warning is:
> 
> WARNING: function definition argument 'struct r8152 *' should
> also have an identifier name
> 739: FILE: drivers/net/usb/r8152.c:739:
> +               void (*init)(struct r8152 *);
> 
> So, fix those warnings by adding the identifier names.
> 
> While we are at it, also fix a character limit violation which was
> causing another checkpatch warning.
> 
> Change-Id: Idec857ce2dc9592caf3173188be1660052c052ce
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> Reviewed-by: Grant Grundler <grundler@chromium.org>

Acked-by: Hayes Wang <hayeswang@realtek.com>

Best Regards,
Hayes


  reply	other threads:[~2019-10-03  2:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 21:09 [PATCH net-next] r8152: Add identifier names for function pointers Prashant Malani
2019-10-03  2:03 ` Hayes Wang [this message]
2019-10-03 15:51 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0835B3720019904CB8F7AA43166CEEB2F18E612E@RTITMBSVM03.realtek.com.tw \
    --to=hayeswang@realtek.com \
    --cc=grundler@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pmalani@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).