From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com,
roopa@cumulusnetworks.com, mlxsw@mellanox.com,
Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next v2 02/10] ipv4: Encapsulate function arguments in a struct
Date: Tue, 14 Jan 2020 08:39:40 -0700 [thread overview]
Message-ID: <0f99fc24-09ad-6f44-dec1-d2a5682af502@gmail.com> (raw)
In-Reply-To: <20200114112318.876378-3-idosch@idosch.org>
On 1/14/20 4:23 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@mellanox.com>
>
> fib_dump_info() is used to prepare RTM_{NEW,DEL}ROUTE netlink messages
> using the passed arguments. Currently, the function takes 11 arguments,
> 6 of which are attributes of the route being dumped (e.g., prefix, TOS).
>
> The next patch will need the function to also dump to user space an
> indication if the route is present in hardware or not. Instead of
> passing yet another argument, change the function to take a struct
> containing the different route attributes.
>
> v2:
> * Name last argument of fib_dump_info()
> * Move 'struct fib_rt_info' to include/net/ip_fib.h so that it could
> later be passed to fib_alias_hw_flags_set()
>
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> ---
> include/net/ip_fib.h | 9 +++++++++
> net/ipv4/fib_lookup.h | 5 ++---
> net/ipv4/fib_semantics.c | 26 ++++++++++++++++----------
> net/ipv4/fib_trie.c | 14 +++++++++-----
> net/ipv4/route.c | 12 +++++++++---
> 5 files changed, 45 insertions(+), 21 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2020-01-14 15:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 11:23 [PATCH net-next v2 00/10] net: Add route offload indication Ido Schimmel
2020-01-14 11:23 ` [PATCH net-next v2 01/10] ipv4: Replace route in list before notifying Ido Schimmel
2020-01-14 11:23 ` [PATCH net-next v2 02/10] ipv4: Encapsulate function arguments in a struct Ido Schimmel
2020-01-14 15:39 ` David Ahern [this message]
2020-01-14 16:35 ` Jiri Pirko
2020-01-14 11:23 ` [PATCH net-next v2 03/10] ipv4: Add "offload" and "trap" indications to routes Ido Schimmel
2020-01-14 15:43 ` David Ahern
2020-01-14 16:39 ` Jiri Pirko
2020-01-14 11:23 ` [PATCH net-next v2 04/10] ipv6: " Ido Schimmel
2020-01-14 11:23 ` [PATCH net-next v2 05/10] mlxsw: spectrum_router: Separate nexthop offload indication from route Ido Schimmel
2020-01-14 11:23 ` [PATCH net-next v2 06/10] mlxsw: spectrum_router: Set hardware flags for routes Ido Schimmel
2020-01-14 16:41 ` Jiri Pirko
2020-01-14 11:23 ` [PATCH net-next v2 07/10] netdevsim: fib: Add dummy implementation for FIB offload Ido Schimmel
2020-01-14 16:54 ` Jiri Pirko
2020-01-14 11:23 ` [PATCH net-next v2 08/10] selftests: forwarding: Add helpers and tests " Ido Schimmel
2020-01-14 11:23 ` [PATCH net-next v2 09/10] selftests: netdevsim: Add test for FIB offload API Ido Schimmel
2020-01-14 11:23 ` [PATCH net-next v2 10/10] selftests: mlxsw: " Ido Schimmel
2020-01-15 2:54 ` [PATCH net-next v2 00/10] net: Add route offload indication David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f99fc24-09ad-6f44-dec1-d2a5682af502@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).