Re: [PATCH 1/2] wifi: brcmfmac: Demote vendor-specific attach/detach messages to info

From: Hector Martin <marcan@marcan.st>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Arend van Spriel <aspriel@gmail.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Kalle Valo <kvalo@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, asahi@lists.linux.dev,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/2] wifi: brcmfmac: Demote vendor-specific attach/detach messages to info
Date: Mon, 17 Apr 2023 17:13:43 +0900	[thread overview]
Message-ID: <1201f65f-1b92-a121-05af-9f0290eb0c47@marcan.st> (raw)
In-Reply-To: <ZDz-F50Zlwkf2njN@kroah.com>

On 17/04/2023 17.06, Greg KH wrote:
> On Mon, Apr 17, 2023 at 04:54:33PM +0900, Hector Martin wrote:
>> On 16/04/2023 21.46, Greg KH wrote:
>>> On Sun, Apr 16, 2023 at 09:42:17PM +0900, Hector Martin wrote:
>>>> People are getting spooked by brcmfmac errors on their boot console.
>>>> There's no reason for these messages to be errors.
>>>>
>>>> Cc: stable@vger.kernel.org
>>>> Fixes: d6a5c562214f ("wifi: brcmfmac: add support for vendor-specific firmware api")
>>>> Signed-off-by: Hector Martin <marcan@marcan.st>
>>>> ---
>>>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c | 4 ++--
>>>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 ++--
>>>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++--
>>>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c
>>>> index ac3a36fa3640..c83bc435b257 100644
>>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c
>>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c
>>>> @@ -12,13 +12,13 @@
>>>>  
>>>>  static int brcmf_bca_attach(struct brcmf_pub *drvr)
>>>>  {
>>>> -	pr_err("%s: executing\n", __func__);
>>>> +	pr_info("%s: executing\n", __func__);
>>>
>>> Why are these here at all?  Please just remove these entirely, you can
>>> get this information normally with ftrace.
>>>
>>> Or, just delete these functions, why have empty ones at all?
>>
>> This is a new WIP code path that Arend introduced which currently
>> deliberately does nothing (but is intended to hold firmware vendor
>> specific init in the future). So we can just drop the messages, but I
>> don't think we want to remove the code entirely.
> 
> Why have empty functions that do nothing?  If you want to put
> vendor-specific anything in here, add it when that is needed.  We don't
> like having dead code laying around in the kernel if at all possible.

That's a question for Arend. But I think we should not be blocking this
fix on that. I'll send a v2 that just removes the messages.

- Hector