On 6/29/20 6:23 PM, Michael Walle wrote: > Hi Marc, > >> I've cleaned up the patches a bit, can you test this branch: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=flexcan > > This is working, but as Joakim already said, CAN-FD ISO mode is missing. > It defaults to non-ISO mode, which is even worse, IMHO. > > But I've also noticed a difference between the original patch and the > one in that branch. When FD mode is enabled the original patch checks > the priv->can.controlmode [1], the patch in the branch looks at > priv->can.ctrlmode_supported instead [2], is that correct? Nope, I've corrected this. thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |