From: David Ahern <dsahern@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: Julian Anastasov <ja@ssi.bg>
Subject: Re: [Patch net] fib: relax source validation check for loopback packets
Date: Sat, 13 Jul 2019 18:29:17 -0600 [thread overview]
Message-ID: <128233e2-aa2c-d2a0-6249-68fd927a299f@gmail.com> (raw)
In-Reply-To: <8355af23-100f-a3bb-0759-fca8b0aa583b@gmail.com>
On 7/13/19 4:42 PM, David Ahern wrote:
> On 7/12/19 2:17 PM, Cong Wang wrote:
>> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
>> index 317339cd7f03..8662a44a28f9 100644
>> --- a/net/ipv4/fib_frontend.c
>> +++ b/net/ipv4/fib_frontend.c
>> @@ -388,6 +388,12 @@ static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst,
>> fib_combine_itag(itag, &res);
>>
>> dev_match = fib_info_nh_uses_dev(res.fi, dev);
>> + /* This is rare, loopback packets retain skb_dst so normally they
>> + * would not even hit this slow path.
>> + */
>> + dev_match = dev_match || (res.type == RTN_LOCAL &&
>> + dev == net->loopback_dev &&
>
> The dev should not be needed. res.type == RTN_LOCAL should be enough, no?
>
nevermind, I see why you have the dev check.
next prev parent reply other threads:[~2019-07-14 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 20:17 [Patch net] fib: relax source validation check for loopback packets Cong Wang
2019-07-13 22:42 ` David Ahern
2019-07-14 0:29 ` David Ahern [this message]
2019-07-14 6:30 ` Cong Wang
2019-07-14 6:33 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=128233e2-aa2c-d2a0-6249-68fd927a299f@gmail.com \
--to=dsahern@gmail.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).