From: Saeed Mahameed <saeedm@mellanox.com>
To: "jes.sorensen@gmail.com" <jes.sorensen@gmail.com>
Cc: "kernel-team@fb.com" <kernel-team@fb.com>,
"jsorensen@fb.com" <jsorensen@fb.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 0/1] Fix broken build of mlx5
Date: Tue, 25 Jun 2019 17:54:16 +0000 [thread overview]
Message-ID: <134e3a684c27fddeeeac111e5b4fac4093473731.camel@mellanox.com> (raw)
In-Reply-To: <20190625152708.23729-1-Jes.Sorensen@gmail.com>
On Tue, 2019-06-25 at 11:27 -0400, Jes Sorensen wrote:
> From: Jes Sorensen <jsorensen@fb.com>
>
> This fixes an obvious build error that could have been caught by
> simply building the code before pushing out the patch.
>
Hi Jes,
Just tested again, as I have tested before submitting the blamed patch,
and as we test on every single new patch in our build automation.
both combinations CONFIG_MLX5_EN_RXNFC=y/n work on latest net-next,
what am i missing ?
> Cheers,
> Jes
>
>
> Jes Sorensen (1):
> mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled
>
> drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
next prev parent reply other threads:[~2019-06-25 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 15:27 [PATCH 0/1] Fix broken build of mlx5 Jes Sorensen
2019-06-25 15:27 ` [PATCH 1/1] mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled Jes Sorensen
2019-06-25 18:00 ` Saeed Mahameed
2019-07-02 15:00 ` Jes Sorensen
2019-06-25 20:34 ` David Miller
2019-06-25 21:01 ` Saeed Mahameed
2019-06-25 21:08 ` David Miller
2019-06-26 19:08 ` Saeed Mahameed
2019-06-25 17:54 ` Saeed Mahameed [this message]
2019-06-25 18:01 ` [PATCH 0/1] Fix broken build of mlx5 Jes Sorensen
2019-06-25 21:11 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=134e3a684c27fddeeeac111e5b4fac4093473731.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=jes.sorensen@gmail.com \
--cc=jsorensen@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).