netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonas Jensen <jonas.jensen@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	f.fainelli@gmail.com, bhutchings@solarflare.com,
	Jonas Jensen <jonas.jensen@gmail.com>
Subject: [PATCH v3 6/7] net: moxa: generate random address
Date: Mon, 20 Jan 2014 12:13:18 +0100	[thread overview]
Message-ID: <1390216399-27028-6-git-send-email-jonas.jensen@gmail.com> (raw)
In-Reply-To: <1390216399-27028-1-git-send-email-jonas.jensen@gmail.com>

The address register is zero:ed on boot, fill it with a randomly generated
address on probe.

Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>
---

Notes:
    Applies to next-20140120

 drivers/net/ethernet/moxa/moxart_ether.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c
index 6df372f..0f25f4dc 100644
--- a/drivers/net/ethernet/moxa/moxart_ether.c
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -740,6 +740,12 @@ static int moxart_mac_probe(struct platform_device *pdev)
 		goto init_fail;
 	}
 
+	if (!is_valid_ether_addr(ndev->dev_addr)) {
+		eth_hw_addr_random(ndev);
+		netdev_info(ndev, "generated random MAC address %pM\n",
+			    ndev->dev_addr);
+	}
+
 	netdev_dbg(ndev, "%s: IRQ=%d address=%pM\n",
 		   __func__, ndev->irq, ndev->dev_addr);
 
-- 
1.8.2.1

  parent reply	other threads:[~2014-01-20 11:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 11:13 [PATCH v3 1/7] net: moxa: clear TX descriptor length bits between sends Jonas Jensen
2014-01-20 11:13 ` [PATCH v3 2/7] net: moxa: fix build_skb() memory corruption Jonas Jensen
2014-01-20 11:13 ` [PATCH v3 3/7] net: moxa: connect to PHY Jonas Jensen
     [not found]   ` <1390216399-27028-3-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-20 14:57     ` Rob Herring
2014-01-21 13:50       ` Jonas Jensen
2014-01-20 11:13 ` [PATCH v3 4/7] net: moxa: add ethtool support Jonas Jensen
2014-01-20 11:13 ` [PATCH v3 5/7] net: moxa: add IFF_LIVE_ADDR_CHANGE flag Jonas Jensen
2014-01-20 11:13 ` Jonas Jensen [this message]
2014-01-20 11:13 ` [PATCH v3 7/7] net: moxa: use eth_mac_addr() Jonas Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390216399-27028-6-git-send-email-jonas.jensen@gmail.com \
    --to=jonas.jensen@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).