From: Claudiu Manoil <claudiu.manoil@nxp.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: alexandru.marginean@nxp.com, netdev@vger.kernel.org
Subject: [PATCH net-next 4/5] enetc: Drop redundant device node check
Date: Fri, 6 Sep 2019 17:15:43 +0300 [thread overview]
Message-ID: <1567779344-30965-5-git-send-email-claudiu.manoil@nxp.com> (raw)
In-Reply-To: <1567779344-30965-1-git-send-email-claudiu.manoil@nxp.com>
The existence of the DT port node is the first thing checked
at probe time, and probing won't continue if the node is missing.
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
drivers/net/ethernet/freescale/enetc/enetc_pf.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
index 9e9bb6b97c41..ebf2996ebe69 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
@@ -754,11 +754,6 @@ static int enetc_of_get_phy(struct enetc_ndev_priv *priv)
int phy_mode;
int err;
- if (!np) {
- dev_err(priv->dev, "missing ENETC port node\n");
- return -ENODEV;
- }
-
priv->phy_node = of_parse_phandle(np, "phy-handle", 0);
if (!priv->phy_node) {
if (!of_phy_is_fixed_link(np)) {
--
2.17.1
next prev parent reply other threads:[~2019-09-06 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 14:15 [PATCH net-next 0/5] enetc: Link mode init w/o bootloader Claudiu Manoil
2019-09-06 14:15 ` [PATCH net-next 1/5] enetc: Fix if_mode extraction Claudiu Manoil
2019-09-06 19:57 ` Andrew Lunn
2019-09-09 16:24 ` Claudiu Manoil
2019-09-10 7:44 ` Andrew Lunn
2019-09-11 16:01 ` Claudiu Manoil
2019-09-06 14:15 ` [PATCH net-next 2/5] enetc: Make mdio accessors more generic Claudiu Manoil
2019-09-06 19:53 ` Andrew Lunn
2019-09-06 14:15 ` [PATCH net-next 3/5] enetc: Initialize SerDes for SGMII and SXGMII protocols Claudiu Manoil
2019-09-06 20:01 ` Andrew Lunn
2019-09-06 14:15 ` Claudiu Manoil [this message]
2019-09-06 14:15 ` [PATCH net-next 5/5] enetc: Use DT protocol information to set up the ports Claudiu Manoil
2019-09-06 20:06 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567779344-30965-5-git-send-email-claudiu.manoil@nxp.com \
--to=claudiu.manoil@nxp.com \
--cc=alexandru.marginean@nxp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).