netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: zhengbin <zhengbin13@huawei.com>
To: <pkshih@realtek.com>, <kvalo@codeaurora.org>,
	<davem@davemloft.net>, <linux-wireless@vger.kernel.org>,
	<netdev@vger.kernel.org>
Cc: <zhengbin13@huawei.com>
Subject: [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate'
Date: Mon, 30 Sep 2019 16:54:47 +0800	[thread overview]
Message-ID: <1569833692-93288-2-git-send-email-zhengbin13@huawei.com> (raw)
In-Reply-To: <1569833692-93288-1-git-send-email-zhengbin13@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/realtek/rtlwifi/ps.c: In function rtl_ps_set_rf_state:
drivers/net/wireless/realtek/rtlwifi/ps.c:71:19: warning: variable rtstate set but not used [-Wunused-but-set-variable]

It is not used since commit f1d2b4d338bf ("rtlwifi:
rtl818x: Move drivers into new realtek directory")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/net/wireless/realtek/rtlwifi/ps.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c b/drivers/net/wireless/realtek/rtlwifi/ps.c
index 70f04c2..e13913a 100644
--- a/drivers/net/wireless/realtek/rtlwifi/ps.c
+++ b/drivers/net/wireless/realtek/rtlwifi/ps.c
@@ -68,7 +68,6 @@ static bool rtl_ps_set_rf_state(struct ieee80211_hw *hw,
 {
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
-	enum rf_pwrstate rtstate;
 	bool actionallowed = false;
 	u16 rfwait_cnt = 0;

@@ -102,8 +101,6 @@ static bool rtl_ps_set_rf_state(struct ieee80211_hw *hw,
 		}
 	}

-	rtstate = ppsc->rfpwr_state;
-
 	switch (state_toset) {
 	case ERFON:
 		ppsc->rfoff_reason &= (~changesource);
--
2.7.4


  reply	other threads:[~2019-09-30  8:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30  8:54 [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables zhengbin
2019-09-30  8:54 ` zhengbin [this message]
2019-10-02  4:33   ` [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate' Kalle Valo
2019-09-30  8:54 ` [PATCH 2/6] rtlwifi: Remove set but not used variables 'dataempty','hoffset' zhengbin
2019-09-30  8:54 ` [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
2019-10-01  9:38   ` Pkshih
2019-10-02  4:26   ` Kalle Valo
2019-09-30  8:54 ` [PATCH 4/6] rtlwifi: rtl8192ee: Remove set but not used variables 'short_gi','buf_len' zhengbin
2019-09-30  8:54 ` [PATCH 5/6] rtlwifi: rtl8192ee: Remove set but not used variables 'reg_ecc','reg_eac' zhengbin
2019-09-30  8:54 ` [PATCH 6/6] rtlwifi: rtl8723be: " zhengbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1569833692-93288-2-git-send-email-zhengbin13@huawei.com \
    --to=zhengbin13@huawei.com \
    --cc=davem@davemloft.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).