From: Paul Moore <pmoore@redhat.com>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
James Morris <james.l.morris@oracle.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [Patch net-next 7/7] selinux: use generic union inet_addr
Date: Mon, 22 Jul 2013 16:36:07 -0400 [thread overview]
Message-ID: <15803221.LSzpdzDYPS@sifl> (raw)
In-Reply-To: <1374476713-8838-8-git-send-email-amwang@redhat.com>
On Monday, July 22, 2013 03:05:13 PM Cong Wang wrote:
> diff --git a/include/linux/lsm_audit.h b/include/linux/lsm_audit.h
> index 1cc89e9..db7c0d6 100644
> --- a/include/linux/lsm_audit.h
> +++ b/include/linux/lsm_audit.h
> @@ -21,6 +21,7 @@
> #include <linux/path.h>
> #include <linux/key.h>
> #include <linux/skbuff.h>
> +#include <net/inet_addr.h>
>
> struct lsm_network_audit {
> int netif;
> @@ -28,16 +29,8 @@ struct lsm_network_audit {
> u16 family;
> __be16 dport;
> __be16 sport;
> - union {
> - struct {
> - __be32 daddr;
> - __be32 saddr;
> - } v4;
> - struct {
> - struct in6_addr daddr;
> - struct in6_addr saddr;
> - } v6;
> - } fam;
> + union inet_addr saddr;
> + union inet_addr daddr;
> };
>
> /* Auxiliary data to use in generating the audit record. */
> @@ -83,9 +76,6 @@ struct common_audit_data {
> }; /* per LSM data pointer union */
> };
>
> -#define v4info fam.v4
> -#define v6info fam.v6
These changes are going to affect Smack as well. You either need to respin
this patch to include all of the LSMs (Smack should be the only other affected
LSM) or add a new patch to the patchset.
--
paul moore
security and virtualization @ redhat
next prev parent reply other threads:[~2013-07-22 20:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 7:05 [Patch net-next 0/7] net: introduce generic type and helpers for IP address Cong Wang
2013-07-22 7:05 ` [Patch net-next 1/7] net: introduce generic union inet_addr Cong Wang
2013-07-22 7:05 ` [Patch net-next 2/7] net: introduce generic simple_inet_pton() Cong Wang
2013-07-22 7:05 ` [Patch net-next 3/7] inetpeer: use generic union inet_addr Cong Wang
2013-07-22 15:18 ` Eric Dumazet
2013-07-23 2:05 ` Cong Wang
2013-07-23 2:26 ` Eric Dumazet
2013-07-23 3:38 ` Cong Wang
2013-07-22 7:05 ` [Patch net-next 4/7] sunrpc: " Cong Wang
[not found] ` <1374476713-8838-5-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-07-23 16:40 ` J. Bruce Fields
[not found] ` <20130723164051.GE12569-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-07-25 12:34 ` Cong Wang
2013-07-25 12:54 ` J. Bruce Fields
2013-07-22 7:05 ` [Patch net-next 5/7] fs: use generic union inet_addr and help functions Cong Wang
2013-07-22 7:05 ` [Patch net-next 6/7] sctp: use generic union inet_addr Cong Wang
2013-07-22 7:05 ` [Patch net-next 7/7] selinux: " Cong Wang
2013-07-22 20:36 ` Paul Moore [this message]
2013-07-23 2:07 ` Cong Wang
2013-07-22 20:44 ` [Patch net-next 0/7] net: introduce generic type and helpers for IP address Joe Perches
2013-07-23 2:00 ` Cong Wang
2013-07-23 2:16 ` Joe Perches
2013-07-23 2:26 ` Cong Wang
2013-07-24 21:28 ` David Miller
2013-07-25 12:30 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15803221.LSzpdzDYPS@sifl \
--to=pmoore@redhat.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eparis@parisplace.org \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).