From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
kuniyu@amazon.com, willemb@google.com
Subject: Re: [PATCH net] af_packet: do not use READ_ONCE() in packet_bind()
Date: Tue, 30 May 2023 05:20:19 +0000 [thread overview]
Message-ID: <168542401973.30709.17193286061562512197.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230526154342.2533026-1-edumazet@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 26 May 2023 15:43:42 +0000 you wrote:
> A recent patch added READ_ONCE() in packet_bind() and packet_bind_spkt()
>
> This is better handled by reading pkt_sk(sk)->num later
> in packet_do_bind() while appropriate lock is held.
>
> READ_ONCE() in writers are often an evidence of something being wrong.
>
> [...]
Here is the summary with links:
- [net] af_packet: do not use READ_ONCE() in packet_bind()
https://git.kernel.org/netdev/net/c/6ffc57ea0042
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-05-30 5:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 15:43 [PATCH net] af_packet: do not use READ_ONCE() in packet_bind() Eric Dumazet
2023-05-26 16:09 ` Willem de Bruijn
2023-05-26 16:14 ` Jiri Pirko
2023-05-26 16:23 ` Kuniyuki Iwashima
2023-05-30 5:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168542401973.30709.17193286061562512197.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).