From: Igor Russkikh <irusskikh@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Ariel Elior" <aelior@marvell.com>,
Michal Kalderon <mkalderon@marvell.com>,
"Denis Bolotin" <dbolotin@marvell.com>,
Jiri Pirko <jiri@resnulli.us>,
"Alexander Lobakin" <alobakin@marvell.com>
Subject: Re: [PATCH v4 net-next 04/10] qed: implement devlink info request
Date: Sat, 1 Aug 2020 11:22:25 +0300 [thread overview]
Message-ID: <1a454a82-98a8-d08a-7769-f4dd02658e51@marvell.com> (raw)
In-Reply-To: <20200731130402.2288f44a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
>> Thus, here we create and store a private copy of this structure
>> in qed_dev root object.
>
> Please include example output of devlink info on you device.
Hi Jakub, will do. Here is an example:
~$ sudo ~/iproute2/devlink/devlink dev info
pci/0000:01:00.0:
driver qed
serial_number REE1915E44552
versions:
running:
fw 8.42.2.0
stored:
fw.mgmt 8.52.10.0
pci/0000:01:00.1:
driver qed
serial_number REE1915E44552
versions:
running:
fw 8.42.2.0
stored:
fw.mgmt 8.52.10.0
>> + memcpy(buf, cdev->hwfns[0].hw_info.part_num,
> sizeof(cdev->hwfns[0].hw_info.part_num));
>> + buf[sizeof(cdev->hwfns[0].hw_info.part_num)] = 0;
>
> Part number != serial number. What's the thing you're reporting here
> actually identifying.
From user manual and configuration point of view thats a serial number.
Existing internal structures name that as part number, double checked
the documentation - in this hardware manual these two things are the same.
> DEVLINK_INFO_VERSION_GENERIC_FW_MGMT, buf);
>> + if (err)
>> + return err;
>
> Assuming MFW means management FW - this looks good.
>> + return devlink_info_version_running_put(req,
Right,
> DEVLINK_INFO_VERSION_GENERIC_FW, buf);
>
> But what's this one?
This one is a fast path firmware which is being loaded from driver
dynamically. I can put this explanation to the patch description.
Regards
Igor
next prev parent reply other threads:[~2020-08-01 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 5:53 [PATCH v4 net-next 00/10] qed: introduce devlink health support Igor Russkikh
2020-07-31 5:53 ` [PATCH v4 net-next 01/10] qed: move out devlink logic into a new file Igor Russkikh
2020-07-31 5:53 ` [PATCH v4 net-next 02/10] qed/qede: make devlink survive recovery Igor Russkikh
2020-07-31 5:53 ` [PATCH v4 net-next 03/10] qed: fix kconfig help entries Igor Russkikh
2020-07-31 5:53 ` [PATCH v4 net-next 04/10] qed: implement devlink info request Igor Russkikh
2020-07-31 20:04 ` Jakub Kicinski
2020-08-01 8:22 ` Igor Russkikh [this message]
2020-07-31 5:53 ` [PATCH v4 net-next 05/10] qed: health reporter init deinit seq Igor Russkikh
2020-07-31 5:53 ` [PATCH v4 net-next 06/10] qed: use devlink logic to report errors Igor Russkikh
2020-07-31 5:53 ` [PATCH v4 net-next 07/10] qed*: make use of devlink recovery infrastructure Igor Russkikh
2020-07-31 5:53 ` [PATCH v4 net-next 08/10] qed: implement devlink dump Igor Russkikh
2020-07-31 5:54 ` [PATCH v4 net-next 09/10] qed: align adjacent indent Igor Russkikh
2020-07-31 5:54 ` [PATCH v4 net-next 10/10] qede: make driver reliable on unload after failures Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a454a82-98a8-d08a-7769-f4dd02658e51@marvell.com \
--to=irusskikh@marvell.com \
--cc=aelior@marvell.com \
--cc=alobakin@marvell.com \
--cc=davem@davemloft.net \
--cc=dbolotin@marvell.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).