From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131
Date: Tue, 27 Oct 2020 20:56:09 +0000 [thread overview]
Message-ID: <1b1d4c27-570b-8a2f-698b-d82b2ca8215d@alliedtelesis.co.nz> (raw)
In-Reply-To: <20201023224216.GE745568@lunn.ch>
On 24/10/20 11:42 am, Andrew Lunn wrote:
>> +int mv88e6123_serdes_get_regs_len(struct mv88e6xxx_chip *chip, int port)
>> +{
>> + if (mv88e6xxx_serdes_get_lane(chip, port) == 0)
>> + return 0;
>> +
>> + return 26 * sizeof(u16);
>> +}
> Hi Chris
>
> Where did 26 come from?
In the 88E6123 Serdes Register Description the highest register address
was 26 so that's what I used. Technically there are 32 possible
addresses in that space so I could go up to 32. Equally registers 9-14,
20, 22-23 are "reserved" so I could remove them from the total and have
mv88e6123_serdes_get_regs() skip over them. I'm guessing skipping some
(27-32) and not others is probably less than ideal.
next prev parent reply other threads:[~2020-10-27 20:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 1:25 [PATCH 0/4] net: dsa: mv88e6xxx: serdes link without phy Chris Packham
2020-10-22 1:25 ` [PATCH 1/4] net: dsa: mv88e6xxx: Don't force link when using in-band-status Chris Packham
2020-10-22 1:25 ` [PATCH 2/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097/6095/6185 Chris Packham
2020-10-22 1:25 ` [PATCH 3/4] net: dsa: mv88e6xxx: Handle error in serdes_get_regs Chris Packham
2020-10-23 22:39 ` Andrew Lunn
2020-10-22 1:25 ` [PATCH 4/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131 Chris Packham
2020-10-23 22:42 ` Andrew Lunn
2020-10-27 20:56 ` Chris Packham [this message]
2020-10-27 21:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b1d4c27-570b-8a2f-698b-d82b2ca8215d@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).